This is an archive of the discontinued LLVM Phabricator instance.

Differential D107864

[hwasan] Fix test with TCO eliminating free frame.
ClosedPublic

Authored by fmayer on Aug 10 2021, 1:02 PM.

Details

Reviewers
eugenis
Commits
rGab41f37ef6e2: [hwasan] Fix test with TCO eliminating free frame.
Summary

This broke https://lab.llvm.org/buildbot/#/builders/37/builds/6016/steps/10/logs/stdio

Diff Detail

Event Timeline

fmayer requested review of this revision.Aug 10 2021, 1:02 PM
fmayer created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2021, 1:02 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
fmayer added a reviewer: eugenis.Aug 10 2021, 1:03 PM
fmayer mentioned this in D107816: [hwasan] Fix test on x86..
eugenis accepted this revision.Aug 10 2021, 1:19 PM

LGTM

This revision is now accepted and ready to land.Aug 10 2021, 1:19 PM
Harbormaster completed remote builds in B118963: Diff 365595.Aug 10 2021, 1:34 PM
Closed by commit rGab41f37ef6e2: [hwasan] Fix test with TCO eliminating free frame. (authored by fmayer). · Explain WhyAug 11 2021, 1:52 AM
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rGab41f37ef6e2: [hwasan] Fix test with TCO eliminating free frame..

Revision Contents

PathSize
compiler-rt/
test/
hwasan/
TestCases/
4 lines

Diff 365595

compiler-rt/test/hwasan/TestCases/double-free.c

Show All 9 Linesint main() {
__hwasan_enable_allocator_tagging(); __hwasan_enable_allocator_tagging();
char * volatile x = (char*)malloc(40); char * volatile x = (char*)malloc(40);
free(x); free(x);
free(x); free(x);
// CHECK: ERROR: HWAddressSanitizer: invalid-free on address {{.*}} at pc {{[0x]+}}[[PC:.*]] on thread T{{[0-9]+}} // CHECK: ERROR: HWAddressSanitizer: invalid-free on address {{.*}} at pc {{[0x]+}}[[PC:.*]] on thread T{{[0-9]+}}
// CHECK: tags: [[PTR_TAG:..]]/[[MEM_TAG:..]] (ptr/mem) // CHECK: tags: [[PTR_TAG:..]]/[[MEM_TAG:..]] (ptr/mem)
// CHECK: #0 {{[0x]+}}{{.*}}[[PC]] // CHECK: #0 {{[0x]+}}{{.*}}[[PC]]
// If we instrument using calls (default on x86), free is not the top frame // If we instrument using calls (default on x86), free is not the top frame
// of the fault. // of the fault. With TCO the free frame can be replaced with the interceptor.
// CHECK: in free // CHECK: in {{.*}}free
// CHECK: freed by thread {{.*}} here: // CHECK: freed by thread {{.*}} here:
// CHECK: previously allocated here: // CHECK: previously allocated here:
// CHECK: Memory tags around the buggy address (one tag corresponds to 16 bytes): // CHECK: Memory tags around the buggy address (one tag corresponds to 16 bytes):
// CHECK: =>{{.*}}[[MEM_TAG]] // CHECK: =>{{.*}}[[MEM_TAG]]
fprintf(stderr, "DONE\n"); fprintf(stderr, "DONE\n");
__hwasan_disable_allocator_tagging(); __hwasan_disable_allocator_tagging();
// CHECK-NOT: DONE // CHECK-NOT: DONE
} }