This is an archive of the discontinued LLVM Phabricator instance.

Differential D107805

[NFC][X86] New Test Requires Asserts
ClosedPublic

Authored by lenary on Aug 10 2021, 2:09 AM.

Details

Reviewers
pengfei
Commits
rGb764b1ef2f99: [NFC][X86] New Test Requires Asserts
Summary

D105263 introduced this new test. It fails when asserts are disabled,
due to using a debug option on opt.

Diff Detail

Event Timeline

lenary requested review of this revision.Aug 10 2021, 2:09 AM
lenary created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2021, 2:09 AM
lenary retitled this revision from [X86] New Test Requires Asserts to [NFC][X86] New Test Requires Asserts.Aug 10 2021, 2:12 AM
pengfei accepted this revision.Aug 10 2021, 2:18 AM

LGTM. Thanks Sam for the quick fix.

BTW, is this a buildbot failure? It seems I didn't receive such a notification.

This revision is now accepted and ready to land.Aug 10 2021, 2:18 AM
lenary added a comment.EditedAug 10 2021, 2:21 AM

The error showed up in our downstream tests. I'm not how slow the upstream bots *without* asserts enabled are. I imagine an email will appear soon. (Edited because I got the implication the wrong way around).

This revision was landed with ongoing or failed builds.Aug 10 2021, 2:22 AM
Closed by commit rGb764b1ef2f99: [NFC][X86] New Test Requires Asserts (authored by Archibald Elliott <archibald.elliott@arm.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
lenary added a commit: rGb764b1ef2f99: [NFC][X86] New Test Requires Asserts.
pengfei added a comment.Aug 10 2021, 2:28 AM
In D107805#2936326, @lenary wrote:

The error showed up in our downstream tests. I'm not how slow the upstream bots with asserts enabled are. I imagine an email will appear soon.

I see. Thanks again.

Harbormaster completed remote builds in B118825: Diff 365389.Aug 10 2021, 3:02 AM

Revision Contents

PathSize
llvm/
test/
Analysis/
CostModel/
X86/
1 line

Diff 365391

llvm/test/Analysis/CostModel/X86/interleaved-load-half.ll

; RUN: opt -S -loop-vectorize -debug-only=loop-vectorize -mattr=avx512fp16 %s 2>&1 | FileCheck %s ; RUN: opt -S -loop-vectorize -debug-only=loop-vectorize -mattr=avx512fp16 %s 2>&1 | FileCheck %s
; REQUIRES: asserts
target datalayout = "e-m:e-p:32:32-f64:32:64-f80:32-n8:16:32-S128" target datalayout = "e-m:e-p:32:32-f64:32:64-f80:32-n8:16:32-S128"
target triple = "i386-unknown-linux-gnu" target triple = "i386-unknown-linux-gnu"
@src = common local_unnamed_addr global [120 x half] zeroinitializer, align 4 @src = common local_unnamed_addr global [120 x half] zeroinitializer, align 4
@dst = common local_unnamed_addr global [120 x half] zeroinitializer, align 4 @dst = common local_unnamed_addr global [120 x half] zeroinitializer, align 4
; Function Attrs: norecurse nounwind ; Function Attrs: norecurse nounwind
define void @stride8(half %k, i32 %width_) { define void @stride8(half %k, i32 %width_) {
▲ Show 20 Lines • Show All 131 Lines • Show Last 20 Lines