This is an archive of the discontinued LLVM Phabricator instance.

Differential D10769

[ARM] Cortex-R5 is not VFPOnlySP
ClosedPublic

Authored by javed.absar on Jun 26 2015, 10:06 AM.

Details

Reviewers
rengolin
Commits
rGbced3032e02b: [ARM] Cortex-R5 is not VFPOnlySP
rL240799: [ARM] Cortex-R5 is not VFPOnlySP
Summary

The model in ARM.td describes cortex-r5 as "FeatureVFPOnlySP". This is incorrect as Cortex-R5 TRM Sec 11.1.1 , states "FPU fully supports single-precision and double-precision add, subtract.."

Diff Detail

Repository
rL LLVM

Event Timeline

javed.absar updated this revision to Diff 28570.Jun 26 2015, 10:06 AM
javed.absar retitled this revision from to [ARM] Cortex-R5 is not VFPOnlySP.
javed.absar updated this object.
javed.absar edited the test plan for this revision. (Show Details)
javed.absar set the repository for this revision to rL LLVM.
javed.absar added a subscriber: Unknown Object (MLST).
Herald added subscribers: aemerson, rengolin. · View Herald TranscriptJun 26 2015, 10:06 AM
rengolin accepted this revision.Jun 26 2015, 10:10 AM
rengolin added a reviewer: rengolin.

LGTM.

This revision is now accepted and ready to land.Jun 26 2015, 10:10 AM
Closed by commit rL240799: [ARM] Cortex-R5 is not VFPOnlySP (authored by javed.absar). · Explain WhyJun 26 2015, 10:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
ARM/
2 lines
test/
CodeGen/
ARM/
2 lines

Diff 28570

lib/Target/ARM/ARM.td

Context not available.
def : ProcessorModel<"cortex-r5", CortexA8Model, def : ProcessorModel<"cortex-r5", CortexA8Model,
[ProcR5, HasV7Ops, FeatureDB, [ProcR5, HasV7Ops, FeatureDB,
FeatureVFP3, FeatureDSPThumb2, FeatureVFP3, FeatureDSPThumb2,
FeatureHasRAS, FeatureVFPOnlySP, FeatureHasRAS,
FeatureD16, FeatureRClass]>; FeatureD16, FeatureRClass]>;
// FIXME: R7 has currently the same ProcessorModel as A8 and is modelled as R5. // FIXME: R7 has currently the same ProcessorModel as A8 and is modelled as R5.
Context not available.

test/CodeGen/ARM/build-attributes.ll

Context not available.
; CORTEX-R5: .eabi_attribute 23, 3 ; CORTEX-R5: .eabi_attribute 23, 3
; CORTEX-R5: .eabi_attribute 24, 1 ; CORTEX-R5: .eabi_attribute 24, 1
; CORTEX-R5: .eabi_attribute 25, 1 ; CORTEX-R5: .eabi_attribute 25, 1
; CORTEX-R5: .eabi_attribute 27, 1 ; CORTEX-R5-NOT: .eabi_attribute 27, 1
; CORTEX-R5-NOT: .eabi_attribute 28 ; CORTEX-R5-NOT: .eabi_attribute 28
; CORTEX-R5-NOT: .eabi_attribute 36 ; CORTEX-R5-NOT: .eabi_attribute 36
; CORTEX-R5: .eabi_attribute 38, 1 ; CORTEX-R5: .eabi_attribute 38, 1
Context not available.