This is an archive of the discontinued LLVM Phabricator instance.

Differential D107342

tsan: remove mallopt calls
ClosedPublic

Authored by dvyukov on Aug 3 2021, 4:51 AM.

Details

Reviewers
vitalybuka
melver
Commits
rGac2bc4e0fc4c: tsan: remove mallopt calls
Summary

mallopt calls are left-over from the times we used
libc_malloc/libc_free for internal allocations.
Now we have own internal allocator, so this is not needed.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Aug 3 2021, 4:51 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2021, 4:51 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B117609: Diff 363700.Aug 3 2021, 5:28 AM
melver accepted this revision.Aug 3 2021, 6:26 AM
This revision is now accepted and ready to land.Aug 3 2021, 6:26 AM
This revision was landed with ongoing or failed builds.Aug 3 2021, 7:18 AM
Closed by commit rGac2bc4e0fc4c: tsan: remove mallopt calls (authored by dvyukov). · Explain Why
This revision was automatically updated to reflect the committed changes.
dvyukov added a commit: rGac2bc4e0fc4c: tsan: remove mallopt calls.

Revision Contents

PathSize
compiler-rt/
lib/
tsan/
rtl/
9 lines

Diff 363730

compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp

Show First 20 Lines • Show All 90 Lines • ▼ Show 20 Lines
DECLARE_REAL_AND_INTERCEPTOR(void *, malloc, uptr size) DECLARE_REAL_AND_INTERCEPTOR(void *, malloc, uptr size)
DECLARE_REAL_AND_INTERCEPTOR(void, free, void *ptr) DECLARE_REAL_AND_INTERCEPTOR(void, free, void *ptr)
extern "C" void *pthread_self(); extern "C" void *pthread_self();
extern "C" void _exit(int status); extern "C" void _exit(int status);
#if !SANITIZER_NETBSD #if !SANITIZER_NETBSD
extern "C" int fileno_unlocked(void *stream); extern "C" int fileno_unlocked(void *stream);
extern "C" int dirfd(void *dirp); extern "C" int dirfd(void *dirp);
#endif #endif
#if SANITIZER_GLIBC
extern "C" int mallopt(int param, int value);
#endif
#if SANITIZER_NETBSD #if SANITIZER_NETBSD
extern __sanitizer_FILE __sF[]; extern __sanitizer_FILE __sF[];
#else #else
extern __sanitizer_FILE *stdout, *stderr; extern __sanitizer_FILE *stdout, *stderr;
#endif #endif
#if !SANITIZER_FREEBSD && !SANITIZER_MAC && !SANITIZER_NETBSD #if !SANITIZER_FREEBSD && !SANITIZER_MAC && !SANITIZER_NETBSD
const int PTHREAD_MUTEX_RECURSIVE = 1; const int PTHREAD_MUTEX_RECURSIVE = 1;
const int PTHREAD_MUTEX_RECURSIVE_NP = 1; const int PTHREAD_MUTEX_RECURSIVE_NP = 1;
▲ Show 20 Lines • Show All 2,553 Lines • ▼ Show 20 Lines
void InitializeInterceptors() { void InitializeInterceptors() {
#if !SANITIZER_MAC #if !SANITIZER_MAC
// We need to setup it early, because functions like dlsym() can call it. // We need to setup it early, because functions like dlsym() can call it.
REAL(memset) = internal_memset; REAL(memset) = internal_memset;
REAL(memcpy) = internal_memcpy; REAL(memcpy) = internal_memcpy;
#endif #endif
// Instruct libc malloc to consume less memory.
#if SANITIZER_GLIBC
mallopt(1, 0); // M_MXFAST
mallopt(-3, 32*1024); // M_MMAP_THRESHOLD
#endif
new(interceptor_ctx()) InterceptorContext(); new(interceptor_ctx()) InterceptorContext();
InitializeCommonInterceptors(); InitializeCommonInterceptors();
InitializeSignalInterceptors(); InitializeSignalInterceptors();
InitializeLibdispatchInterceptors(); InitializeLibdispatchInterceptors();
#if !SANITIZER_MAC #if !SANITIZER_MAC
// We can not use TSAN_INTERCEPT to get setjmp addr, // We can not use TSAN_INTERCEPT to get setjmp addr,
▲ Show 20 Lines • Show All 239 Lines • Show Last 20 Lines