This is an archive of the discontinued LLVM Phabricator instance.

tsan: remove unbalanced mutex unlock
ClosedPublic

Authored by dvyukov on Aug 2 2021, 5:16 AM.

Reviewers

vitalybuka
melver

Commits

rG03372e72d302: tsan: remove unbalanced mutex unlock

Summary

The mutex is now unlocked by the scoped Lock object.

dvyukov requested review of this revision.Aug 2 2021, 5:16 AM

dvyukov created this revision.

Herald added a subscriber: Restricted Project. · View Herald Transcript

This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2021, 5:19 AM

This revision was landed with ongoing or failed builds.

This revision was automatically updated to reflect the committed changes.

Path

Size

compiler-rt/

lib/

tsan/

rtl/

1 line

Show First 20 Lines • Show All 198 Lines • ▼ Show 20 Lines	if (first && common_flags()->detect_deadlocks) {
pre_lock =		pre_lock =
(flagz & MutexFlagDoPreLockOnPostLock) && !(flagz & MutexFlagTryLock);		(flagz & MutexFlagDoPreLockOnPostLock) && !(flagz & MutexFlagTryLock);
Callback cb(thr, pc);		Callback cb(thr, pc);
if (pre_lock)		if (pre_lock)
ctx->dd->MutexBeforeLock(&cb, &s->dd, true);		ctx->dd->MutexBeforeLock(&cb, &s->dd, true);
ctx->dd->MutexAfterLock(&cb, &s->dd, true, flagz & MutexFlagTryLock);		ctx->dd->MutexAfterLock(&cb, &s->dd, true, flagz & MutexFlagTryLock);
}		}
mid = s->GetId();		mid = s->GetId();
s->mtx.Unlock();
}		}
if (report_double_lock)		if (report_double_lock)
ReportMutexMisuse(thr, pc, ReportTypeMutexDoubleLock, addr, mid);		ReportMutexMisuse(thr, pc, ReportTypeMutexDoubleLock, addr, mid);
if (first && pre_lock && common_flags()->detect_deadlocks) {		if (first && pre_lock && common_flags()->detect_deadlocks) {
Callback cb(thr, pc);		Callback cb(thr, pc);
ReportDeadlock(thr, pc, ctx->dd->GetReport(&cb));		ReportDeadlock(thr, pc, ctx->dd->GetReport(&cb));
}		}
}		}
▲ Show 20 Lines • Show All 345 Lines • Show Last 20 Lines