This is an archive of the discontinued LLVM Phabricator instance.

tsan: fix another latent race size bug in test
ClosedPublic

Authored by dvyukov on Jul 30 2021, 3:44 AM.

Details

Summary

The test contains a race in memset.
The size of reported race depends on how the accessed
memory range split into granules inside of tsan runtime.
The test used to report access of size 8, because presumably
the buffer ended up being aligned to 8 bytes. But after
some unrelated changes this test started to report accesses
of size 1 (presumably .data layout changed), which makes
the test fail.
Guarantee alignment of the buf object explicitly.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Jul 30 2021, 3:44 AM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2021, 3:44 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
melver accepted this revision.Jul 30 2021, 3:46 AM
This revision is now accepted and ready to land.Jul 30 2021, 3:46 AM
This revision was landed with ongoing or failed builds.Jul 30 2021, 3:55 AM
This revision was automatically updated to reflect the committed changes.