This is an archive of the discontinued LLVM Phabricator instance.

Differential D107037

tsan: fix java_symbolization test
ClosedPublic

Authored by dvyukov on Jul 28 2021, 10:48 PM.

Details

Reviewers
vitalybuka
melver
Commits
rG262cb5f5b492: tsan: fix java_symbolization test
Summary

We reliably remove bottom libc-guts frames only on linux/glibc.
Some bots failed on this test showing other bottom frames:

.annobin_libc_start.c libc-start.c (libc.so.6+0x249f4)
generic_start_main.isra.0 libc-start.c (libc.so.6+0x45b0c)

We can't reliably remove all of possible bottom frames.
So remove the assertion for that.

Diff Detail

Event Timeline

dvyukov requested review of this revision.Jul 28 2021, 10:48 PM
dvyukov created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2021, 10:48 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Jul 28 2021, 10:48 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG262cb5f5b492: tsan: fix java_symbolization test (authored by dvyukov). · Explain Why
This revision was automatically updated to reflect the committed changes.
dvyukov added a commit: rG262cb5f5b492: tsan: fix java_symbolization test.
Harbormaster completed remote builds in B116878: Diff 362644.Jul 28 2021, 11:36 PM

Revision Contents

PathSize
compiler-rt/
test/
tsan/
3 lines

Diff 362645

compiler-rt/test/tsan/java_symbolization.cpp

Show First 20 Lines • Show All 50 Lines • ▼ Show 20 Lines
} }
// CHECK: WARNING: ThreadSanitizer: data race // CHECK: WARNING: ThreadSanitizer: data race
// CHECK: Write // CHECK: Write
// CHECK: #0 MyInnerFunc MyInnerFile.java:1234:56 // CHECK: #0 MyInnerFunc MyInnerFile.java:1234:56
// CHECK: #1 MyOuterFunc MyOuterFile.java:4321:65 // CHECK: #1 MyOuterFunc MyOuterFile.java:4321:65
// CHECK: #2 Caller1 CallerFile.java:111:22 // CHECK: #2 Caller1 CallerFile.java:111:22
// CHECK: #3 Caller2 CallerFile.java:333:44 // CHECK: #3 Caller2 CallerFile.java:333:44
// CHECK-NOT: #4
// CHECK: Previous write // CHECK: Previous write
// CHECK: #0 MyInnerFunc MyInnerFile.java:1234:56 // CHECK: #0 MyInnerFunc MyInnerFile.java:1234:56
// CHECK: #1 MyOuterFunc MyOuterFile.java:4321:65 // CHECK: #1 MyOuterFunc MyOuterFile.java:4321:65
// CHECK: #2 Caller1 CallerFile.java:111:22 // CHECK: #2 Caller1 CallerFile.java:111:22
// CHECK: #3 Caller2 CallerFile.java:333:44 // CHECK: #3 Caller2 CallerFile.java:333:44
// CHECK-NOT: #4
// CHECK: Location is heap block of size 32 at {{.*}} allocated by main thread: // CHECK: Location is heap block of size 32 at {{.*}} allocated by main thread:
// CHECK: #0 Allocer1 Alloc.java:11:222 // CHECK: #0 Allocer1 Alloc.java:11:222
// CHECK: #1 Allocer2 Alloc.java:33:444 // CHECK: #1 Allocer2 Alloc.java:33:444
// CHECK-NOT: #2
// CHECK: DONE // CHECK: DONE