This is an archive of the discontinued LLVM Phabricator instance.

Driver: Add AMDGPU toolchain
ClosedPublic

Authored by tstellarAMD on Jun 24 2015, 11:03 AM.

Details

Summary

This is a minimal toolchain, which sets the integrated assembler as default,
and uses lld for linking.

Diff Detail

Event Timeline

tstellarAMD retitled this revision from to Driver: Add AMDGPU toolchain.
tstellarAMD updated this object.
tstellarAMD edited the test plan for this revision. (Show Details)
tstellarAMD added reviewers: arsenm, mcrosier.
tstellarAMD added a subscriber: Unknown Object (MLST).
dougk added a subscriber: dougk.Jul 6 2015, 7:52 AM
dougk added inline comments.
lib/Driver/ToolChains.h
726

Please use ToolChain instead of _TC as the suffix.
See http://reviews.llvm.org/D10609 (pending) which standardizes on that.

lib/Driver/Tools.cpp
5759

any reason not to insert getToolChain().getTripleString() vs hardcoding 'amdgcn--' ?

Here is an updated patch. I have renamed AMDGPU_TC to AMDGPUToolChain and
replaced the hard-coded amdgcn-- triple with getToolChain().getTripleString()

tstellarAMD marked 2 inline comments as done.Jul 7 2015, 6:20 AM
mcrosier accepted this revision.Jul 16 2015, 1:16 PM
mcrosier edited edge metadata.

Seems reasonable to me.

This revision is now accepted and ready to land.Jul 16 2015, 1:16 PM
This revision was automatically updated to reflect the committed changes.