Use GetLinkerPath utility function to find linker for NaCl toolchain

[dschuff]

Summary

This is more consistent with other targets and also makes the -fuse-ld
flag work.

[jvoung]

Worth adding a test case to test/Driver/fuse-ld.c ?

Otherwise LGTM

[dschuff]

• broken test. uses system ld.gold

[dschuff]

argh, I keep forgetting that 'git svn dcommit' commits all of your local git commits individually. Sorry about the noise.

lib/Driver/ToolChains.cpp

case llvm::Triple::mipsel: {
     file_paths.push_back(ToolPath + "mipsel-nacl");
     break;
   }
   default:
     break;
   }
 
   // Use provided linker, not system linker
-  Linker = GetProgramPath("ld");
+  Linker = GetLinkerPath();
   NaClArmMacrosPath = GetFilePath("nacl-arm-macros.s");
 }
 
 void NaClToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs,
                                               ArgStringList &CC1Args) const {
   const Driver &D = getDriver();
   if (DriverArgs.hasArg(options::OPT_nostdinc))
     return;

test/Driver/fuse-ld.c

 // RUN:   | FileCheck %s -check-prefix=CHECK-ANDROID-ARM-BFD-TC
 // CHECK-ANDROID-ARM-BFD-TC: Inputs/basic_android_tree/lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin{{/|\\+}}ld.bfd
 
 // RUN: %clang %s -### -fuse-ld=gold \
 // RUN:     -target arm-linux-androideabi \
 // RUN:     -gcc-toolchain %S/Inputs/basic_android_tree 2>&1 \
 // RUN:   | FileCheck %s -check-prefix=CHECK-ANDROID-ARM-GOLD-TC
 // CHECK-ANDROID-ARM-GOLD-TC: Inputs/basic_android_tree/lib/gcc/arm-linux-androideabi/4.4.3/../../../../arm-linux-androideabi/bin{{/|\\+}}ld.gold
+
+// RUN: %clang %s -### -fuse-ld=gold \
+// RUN:     -target i686-unknown-nacl \
+// RUN:     -B%S/Inputs/basic_nacl_tree/bin 2>&1 \
+// RUN:   | FileCheck %s -check-prefix=CHECK-NACL-GOLD-TC
+// CHECK-NACL-GOLD-TC: ld.gold