This is an archive of the discontinued LLVM Phabricator instance.

Differential D106858

[hwasan] Fix stack safety test for old PM.
ClosedPublic

Authored by fmayer on Jul 27 2021, 2:40 AM.

Details

Reviewers
vitalybuka
Commits
rG835ef6f93d57: [hwasan] Fix stack safety test for old PM.
Summary

With the old PM, the stub for __hwasan_generate_tag is still generated
in the IR, but never called.

Diff Detail

Event Timeline

fmayer requested review of this revision.Jul 27 2021, 2:40 AM
fmayer created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2021, 2:40 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
fmayer added a reviewer: vitalybuka.Jul 27 2021, 2:40 AM
fmayer mentioned this in rG96c63492cb95: [hwasan] Use stack safety analysis..Jul 27 2021, 3:00 AM
Harbormaster completed remote builds in B116377: Diff 361953.Jul 27 2021, 3:19 AM
vitalybuka accepted this revision.Jul 27 2021, 10:56 AM
This revision is now accepted and ready to land.Jul 27 2021, 10:56 AM
This revision was landed with ongoing or failed builds.Jul 27 2021, 12:51 PM
Closed by commit rG835ef6f93d57: [hwasan] Fix stack safety test for old PM. (authored by fmayer). · Explain Why
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rG835ef6f93d57: [hwasan] Fix stack safety test for old PM..

Revision Contents

PathSize
clang/
test/
CodeGen/
11 lines

Diff 362143

clang/test/CodeGen/hwasan-stack-safety-analysis.c

// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -emit-llvm -mllvm -hwasan-use-stack-safety=true -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-prefix=SAFETY // RUN: %clang -fno-legacy-pass-manager -fsanitize=hwaddress -target aarch64-linux-gnu -S -emit-llvm -mllvm -hwasan-use-stack-safety=true -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-prefix=SAFETY
// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -emit-llvm -mllvm -hwasan-use-stack-safety=false -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-prefix=NOSAFETY // RUN: %clang -fno-legacy-pass-manager -fsanitize=hwaddress -target aarch64-linux-gnu -S -emit-llvm -mllvm -hwasan-use-stack-safety=false -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-prefix=NOSAFETY
// RUN: %clang -flegacy-pass-manager -fsanitize=hwaddress -target aarch64-linux-gnu -S -emit-llvm -mllvm -hwasan-use-stack-safety=true -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-prefix=SAFETY
// RUN: %clang -flegacy-pass-manager -fsanitize=hwaddress -target aarch64-linux-gnu -S -emit-llvm -mllvm -hwasan-use-stack-safety=false -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-prefix=NOSAFETY
// Default when optimizing, but not with O0. // Default when optimizing, but not with O0.
// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -emit-llvm -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-prefix=SAFETY // RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -emit-llvm -mllvm -hwasan-generate-tags-with-calls -O2 %s -o - | FileCheck %s --check-prefix=SAFETY
// RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -emit-llvm -mllvm -hwasan-generate-tags-with-calls -O0 %s -o - | FileCheck %s --check-prefix=NOSAFETY // RUN: %clang -fsanitize=hwaddress -target aarch64-linux-gnu -S -emit-llvm -mllvm -hwasan-generate-tags-with-calls -O0 %s -o - | FileCheck %s --check-prefix=NOSAFETY
int main(int argc, char **argv) { int main(int argc, char **argv) {
char buf[10]; char buf[10];
volatile char *x = buf; volatile char *x = buf;
*x = 0; *x = 0;
return buf[0]; return buf[0];
// NOSAFETY: __hwasan_generate_tag // NOSAFETY: call i8 @__hwasan_generate_tag
// SAFETY-NOT: __hwasan_generate_tag // SAFETY-NOT: call i8 @__hwasan_generate_tag
} }