In https://reviews.llvm.org/D102861 changes to the LNT suite were made to accommodate the clang patch in https://reviews.llvm.org/D74436 . These changes were made in the CMakeLists.txt. Unfortunately the buildbot seems to be running make. This patch is to add those same (FLAGS) changes in D102861 to the Makefiles.
LGTM - please see changes requested inline. thanks a lot
I think these should all say "+=" instead of merely "=" because there might be an initialization of flags from somewhere else e.g. the Make command line invocation. If you use += then it will add onto the flags, whereas straight assignment I believe would lose the other setting.
If there's no particular reason why some files use CPPFLAGS and others divide into CXXFLAGS and CFLAGS why not use the same setting in each file (i.e. choose one way or the other)
I'm going to go ahead and +1 this assuming you will make these changes
LGTM thanks so much for doing this!
I will change all these to +=.