Page MenuHomePhabricator

[dfsan] Make warn_unimplemented off by default
ClosedPublic

Authored by stephan.yichao.zhao on Jul 22 2021, 2:02 PM.

Details

Reviewers
gbalats
Summary

Because almost all internal use cases need to turn warn_unimplemented off.

Diff Detail

Event Timeline

stephan.yichao.zhao requested review of this revision.Jul 22 2021, 2:02 PM
stephan.yichao.zhao created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2021, 2:02 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

This makes issues silent by default.

Instead, I think we should reduce noise by changing the tool to only report each unimplemented function once.

This makes issues silent by default.

This is a trade off with setting this environment variable or flag explicitly.
No use cases turn this flag on for the time being.

Instead, I think we should reduce noise by changing the tool to only report each unimplemented function once.

I am making another change to report only one warning.

gbalats accepted this revision.Jul 22 2021, 2:45 PM
This revision is now accepted and ready to land.Jul 22 2021, 2:45 PM