This is an archive of the discontinued LLVM Phabricator instance.

[HIP] Fix visibility of __hip_fatbin
ClosedPublic

Authored by yaxunl on Jul 22 2021, 9:54 AM.

Details

Summary

In -fgpu-rdc case, fat binary is embedded as global variable __hip_fatbin.
It needs to have protected visibility to avoid conflict between shared
libraries.

Diff Detail

Event Timeline

yaxunl requested review of this revision.Jul 22 2021, 9:54 AM
yaxunl created this revision.
scchan accepted this revision.Jul 22 2021, 10:36 AM

LGTM

This revision is now accepted and ready to land.Jul 22 2021, 10:36 AM
tra accepted this revision.Jul 22 2021, 5:00 PM
This revision was landed with ongoing or failed builds.Jul 23 2021, 7:15 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2021, 7:15 AM