This is an archive of the discontinued LLVM Phabricator instance.

[vscode] fix ubsan problem in the progress event reporter
ClosedPublic

Authored by wallace on Jul 12 2021, 11:48 AM.

Details

Summary

The error

UndefinedBehaviorSanitizer: undefined-behavior /Users/buildslave/jenkins/workspace/lldb-cmake-sanitized/llvm-project/lldb/tools/lldb-vscode/ProgressEvent.cpp:89:64 in

was found in https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-sanitized/1910/consoleFull#-15641370498254eaf0-7326-4999-85b0-388101f2d404

It turns out that we were not setting m_event_type when initializatin
and update case. The fix is very simple.

Diff Detail

Event Timeline

wallace requested review of this revision.Jul 12 2021, 11:48 AM
wallace created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2021, 11:48 AM
clayborg accepted this revision.Jul 12 2021, 1:22 PM
This revision is now accepted and ready to land.Jul 12 2021, 1:22 PM
This revision was landed with ongoing or failed builds.Jul 12 2021, 1:22 PM
This revision was automatically updated to reflect the committed changes.