This is an archive of the discontinued LLVM Phabricator instance.

Differential D105401

[compiler-rt][iwyu] explicitly includes `<new>` in xray_utils.cpp
ClosedPublic

Authored by cjdb on Jul 3 2021, 7:21 PM.

Details

Reviewers
MaskRay
Commits
rG873e8b96b122: [compiler-rt][iwyu] explicitly includes `<new>` in xray_utils.cpp
Summary

Compiling compiler-rt with Clang modules and libc++ revealed that the
global operator new is being called without including <new>.

Diff Detail

Event Timeline

cjdb created this revision.Jul 3 2021, 7:21 PM
Herald added a subscriber: dberris. · View Herald TranscriptJul 3 2021, 7:21 PM
cjdb requested review of this revision.Jul 3 2021, 7:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2021, 7:21 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B112341: Diff 356358.Jul 3 2021, 7:49 PM
MaskRay accepted this revision.Jul 4 2021, 5:28 PM
This revision is now accepted and ready to land.Jul 4 2021, 5:28 PM
Closed by commit rG873e8b96b122: [compiler-rt][iwyu] explicitly includes `<new>` in xray_utils.cpp (authored by cjdb). · Explain WhyJul 5 2021, 2:47 PM
This revision was automatically updated to reflect the committed changes.
cjdb added a commit: rG873e8b96b122: [compiler-rt][iwyu] explicitly includes `<new>` in xray_utils.cpp.

Revision Contents

PathSize
compiler-rt/
lib/
xray/
1 line

Diff 356566

compiler-rt/lib/xray/xray_utils.cpp

Show All 14 Lines
#include "sanitizer_common/sanitizer_common.h" #include "sanitizer_common/sanitizer_common.h"
#include "xray_allocator.h" #include "xray_allocator.h"
#include "xray_defs.h" #include "xray_defs.h"
#include "xray_flags.h" #include "xray_flags.h"
#include <cstdio> #include <cstdio>
#include <errno.h> #include <errno.h>
#include <fcntl.h> #include <fcntl.h>
#include <iterator> #include <iterator>
#include <new>
#include <stdlib.h> #include <stdlib.h>
#include <sys/types.h> #include <sys/types.h>
#include <tuple> #include <tuple>
#include <unistd.h> #include <unistd.h>
#include <utility> #include <utility>
#if SANITIZER_FUCHSIA #if SANITIZER_FUCHSIA
#include "sanitizer_common/sanitizer_symbolizer_fuchsia.h" #include "sanitizer_common/sanitizer_symbolizer_fuchsia.h"
▲ Show 20 Lines • Show All 169 Lines • Show Last 20 Lines