This is an archive of the discontinued LLVM Phabricator instance.

Differential D105136

[lldb] Check for the mangled symbol name for objc_copyRealizedClassList_nolock
ClosedPublic

Authored by JDevlieghere on Jun 29 2021, 10:54 AM.

Details

Reviewers
jingham
Commits
rG71be4db05bbd: [lldb] Check for the mangled symbol name for objc_copyRealizedClassList_nolock
Summary

When we check whether the Objective-C SPI is available, we need to check
for the mangled symbol name. Unlike objc_copyRealizedClassList, which
is C exported, the nolock variant is not.

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Jun 29 2021, 10:54 AM
JDevlieghere created this revision.
jingham accepted this revision.Jun 29 2021, 10:55 AM

LGTM

This revision is now accepted and ready to land.Jun 29 2021, 10:55 AM
JDevlieghere retitled this revision from [lldb Look for the mangled objc_copyRealizedClassList_nolock symbol name to [lldb] Check for the mangled symbol name for objc_copyRealizedClassList_nolock.Jun 29 2021, 10:58 AM
JDevlieghere edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Jun 29 2021, 10:58 AM
Closed by commit rG71be4db05bbd: [lldb] Check for the mangled symbol name for objc_copyRealizedClassList_nolock (authored by JDevlieghere). · Explain Why
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rG71be4db05bbd: [lldb] Check for the mangled symbol name for objc_copyRealizedClassList_nolock.
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2021, 10:58 AM
Harbormaster completed remote builds in B111570: Diff 355296.Jun 29 2021, 11:48 AM

Revision Contents

PathSize
lldb/
source/
Plugins/
LanguageRuntime/
ObjC/
AppleObjCRuntime/
2 lines

Diff 355296

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
m_loaded_objc_opt(false), m_non_pointer_isa_cache_up(), m_loaded_objc_opt(false), m_non_pointer_isa_cache_up(),
m_tagged_pointer_vendor_up( m_tagged_pointer_vendor_up(
TaggedPointerVendorV2::CreateInstance(*this, objc_module_sp)), TaggedPointerVendorV2::CreateInstance(*this, objc_module_sp)),
m_encoding_to_type_sp(), m_noclasses_warning_emitted(false), m_encoding_to_type_sp(), m_noclasses_warning_emitted(false),
m_CFBoolean_values(), m_realized_class_generation_count(0) { m_CFBoolean_values(), m_realized_class_generation_count(0) {
static const ConstString g_gdb_object_getClass("gdb_object_getClass"); static const ConstString g_gdb_object_getClass("gdb_object_getClass");
m_has_object_getClass = HasSymbol(g_gdb_object_getClass); m_has_object_getClass = HasSymbol(g_gdb_object_getClass);
static const ConstString g_objc_copyRealizedClassList( static const ConstString g_objc_copyRealizedClassList(
"objc_copyRealizedClassList_nolock"); "_ZL33objc_copyRealizedClassList_nolockPj");
m_has_objc_copyRealizedClassList = HasSymbol(g_objc_copyRealizedClassList); m_has_objc_copyRealizedClassList = HasSymbol(g_objc_copyRealizedClassList);
RegisterObjCExceptionRecognizer(process); RegisterObjCExceptionRecognizer(process);
} }
bool AppleObjCRuntimeV2::GetDynamicTypeAndAddress( bool AppleObjCRuntimeV2::GetDynamicTypeAndAddress(
ValueObject &in_value, lldb::DynamicValueType use_dynamic, ValueObject &in_value, lldb::DynamicValueType use_dynamic,
TypeAndOrName &class_type_or_name, Address &address, TypeAndOrName &class_type_or_name, Address &address,
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines