Refactor GetVariableInfo/GetValueStringFormatted/GetValue to use the same code (MI), part 2

[ki.stfu]

Summary

This patch should have gone in with svn rev.234476 - it is another refactoring for the handling of escapes and quotes. Note: Ilia is the original author for this patch. Commit message which applies to this patch from Ilia:

Refactor GetVariableInfo/GetValueStringFormatted/GetValue to use the same code (MI)

Also it expands the variable value format for strings (aka char*):
was:
^done,name="v4",numchild="1",value="0x0000000100000f56",type="const char *",thread-id="1",has_more="0"

now:
^done,name="v4",numchild="1",value="0x0000000100000f56 \"ab\"",type="const char *",thread-id="1",has_more="0"

[ki.stfu]

I'm at conference until Monday and will take a look at it later.

[dawn]

Please review? Thank you.

[ki.stfu]

I created a new patch for that: http://reviews.llvm.org/D10728.

tools/lldb-mi/MICmdCmdData.cpp

     {
         const lldb::ValueType eValueType = value.GetValueType();
         MIunused(eValueType);
-        m_strValue = utilValue.GetValue();
-        CMIUtilString strCString;
-        if (CMICmnLLDBProxySBValue::GetCString(value, strCString))
-        {
-            m_strValue += CMIUtilString::Format(" '%s'", strCString.c_str());
-        }
+        m_strValue = utilValue.GetValue().Escape().AddSlashes();
         return MIstatus::success;
     }