Page MenuHomePhabricator

[Polly][Isl] Refactoring IslAstInfo::getBuild() and IslAstInfo::IslAstUserPayload::Build to use isl++. NFC
ClosedPublic

Authored by patacca on Jun 16 2021, 5:13 AM.

Details

Summary

Polly uses algorithms from the Integer Set Library (isl), which is a library written in C and which is incompatible with the rest of the LLVM as it is written in C++.

Changes made:

  • Refactoring the method IslAstInfo::getBuild()
  • IslAstInfo::IslAstUserPayload.Build now uses C++ types instead of C types
  • Removing destructor of IslAstInfo::IslAstUserPayload

Diff Detail

Event Timeline

patacca created this revision.Jun 16 2021, 5:13 AM
patacca added a project: Restricted Project.Jun 16 2021, 5:14 AM
patacca published this revision for review.Jun 16 2021, 6:14 AM
patacca edited the summary of this revision. (Show Details)
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2021, 6:14 AM
Meinersbur accepted this revision.Jun 16 2021, 12:56 PM

LGTM.

Could you remove the backticks from the title before committing? It is not interpreted as Markdown and its shortness is comparatively important (Many guidelines recommend at most 50 characters)

This revision is now accepted and ready to land.Jun 16 2021, 12:56 PM
patacca retitled this revision from [Polly][Isl] Refactoring `IslAstInfo::getBuild()` and `IslAstInfo::IslAstUserPayload::Build` to use isl++. NFC. to [Polly][Isl] Refactoring IslAstInfo::getBuild() and IslAstInfo::IslAstUserPayload::Build to use isl++. NFC.Jun 18 2021, 12:51 AM
This revision was landed with ongoing or failed builds.Jun 18 2021, 12:53 AM
This revision was automatically updated to reflect the committed changes.