Page MenuHomePhabricator

[libc++][🍒] Un-deprecate std::allocator<void>
ClosedPublic

Authored by ldionne on Jun 15 2021, 2:56 PM.

Details

Reviewers
tstellar
ldionne
Group Reviewers
Restricted Project
Summary

This is a cherry-pick of https://reviews.llvm.org/D104323 for backporting
to LLVM 12.

Diff Detail

Unit TestsFailed

TimeTest
2,390 mslibcxx CI ASAN > libc++.std/experimental/language_support/support_coroutines/end_to_end::expected.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++ /home/libcxx-builder/.buildkite-agent/builds/58299461455d-1/llvm-project/libcxx-ci/libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/expected.pass.cpp -v --target=x86_64-unknown-linux-gnu -g -fno-omit-frame-pointer -fsanitize=address -include /home/libcxx-builder/.buildkite-agent/builds/58299461455d-1/llvm-project/libcxx-ci/build/generic-asan/projects/libcxx/__config_site -include /home/libcxx-builder/.buildkite-agent/builds/58299461455d-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/libcxx-builder/.buildkite-agent/builds/58299461455d-1/llvm-project/libcxx-ci/libcxx/include -I/home/libcxx-builder/.buildkite-agent/builds/58299461455d-1/llvm-project/libcxx-ci/build/generic-asan/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/libcxx-builder/.buildkite-agent/builds/58299461455d-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -O1 -std=c++2b -Werror -Wall -Wextra -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/home/libcxx-builder/.buildkite-agent/builds/58299461455d-1/llvm-project/libcxx-ci/build/generic-asan/projects/libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/Output/expected.pass.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -fcoroutines-ts -L/home/libcxx-builder/.buildkite-agent/builds/58299461455d-1/llvm-project/libcxx-ci/build/generic-asan/./lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/58299461455d-1/llvm-project/libcxx-ci/build/generic-asan/./lib…
2,860 mslibcxx CI C++2b > libc++.libcxx/debug/containers::db_sequence_container_iterators.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++-tot /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/libcxx/debug/containers/db_sequence_container_iterators.pass.cpp -v --target=x86_64-unknown-linux-gnu -include /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/__config_site -include /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/include -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2b -Werror -Wall -Wextra -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/test/libcxx/debug/containers/Output/db_sequence_container_iterators.pass.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -D_LIBCPP_DEBUG=1 -L/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/./lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/./lib -nodefaultlibs -lc++ -lm -lgcc_s -lgcc -lpthread -lc -lgcc_s -lgcc -latomic…
3,690 mslibcxx CI C++2b > libc++.libcxx/gdb::gdb_pretty_printer_test.sh.cpp
Script: -- : 'RUN: at line 14'; /usr/bin/clang++-tot -v --target=x86_64-unknown-linux-gnu /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp -o /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/test/libcxx/gdb/Output/gdb_pretty_printer_test.sh.cpp.dir/t.tmp.exe -include /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/__config_site -include /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/include -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2b -Werror -Wall -Wextra -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/test/libcxx/gdb/Output/gdb_pretty_printer_test.sh.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -g -L/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/./lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4…
1,190 mslibcxx CI C++2b > libc++.std/containers/sequences/vector/vector_cons::deduct.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++-tot /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/std/containers/sequences/vector/vector.cons/deduct.pass.cpp -v --target=x86_64-unknown-linux-gnu -include /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/__config_site -include /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/include -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2b -Werror -Wall -Wextra -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/test/std/containers/sequences/vector/vector.cons/Output/deduct.pass.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -L/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/./lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/./lib -nodefaultlibs -lc++ -lm -lgcc_s -lgcc -lpthread -lc -lgcc_s -lgcc -latomic -lc++experimental -o /home/libcxx…
970 mslibcxx CI C++2b > libc++.std/containers/sequences/vector_bool::assign_copy.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++-tot /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/std/containers/sequences/vector.bool/assign_copy.pass.cpp -v --target=x86_64-unknown-linux-gnu -include /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/__config_site -include /home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/include -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/libcxx/test/support -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -std=c++2b -Werror -Wall -Wextra -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fmodules-cache-path=/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/projects/libcxx/test/std/containers/sequences/vector.bool/Output/assign_copy.pass.cpp.dir/t.tmp/ModuleCache -Wno-macro-redefined -D_LIBCPP_HAS_THREAD_API_PTHREAD -Wno-macro-redefined -D_LIBCPP_ABI_VERSION=1 -L/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/./lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3b53210be0a4-1/llvm-project/libcxx-ci/build/generic-cxx2b/./lib -nodefaultlibs -lc++ -lm -lgcc_s -lgcc -lpthread -lc -lgcc_s -lgcc -latomic -lc++experimental -o /home/libcxx…
View Full Test Results (32 Failed)

Event Timeline

ldionne requested review of this revision.Jun 15 2021, 2:56 PM
ldionne created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2021, 2:56 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

This is a manual cherry-pick because the codebase has diverged quite a bit.

@tstellar Once this is passing CI, I'd like to have your permission to merge this to release/12.x because this is a pretty vexing issue.

tstellar added a comment.EditedJun 15 2021, 3:35 PM

This is a manual cherry-pick because the codebase has diverged quite a bit.

@tstellar Once this is passing CI, I'd like to have your permission to merge this to release/12.x because this is a pretty vexing issue.

@ldionne Go ahead and merge when it's ready, and make sure to use git cherry-pick -x.

ldionne updated this revision to Diff 352309.Jun 15 2021, 6:01 PM

Fix CI issues.

This is a manual cherry-pick because the codebase has diverged quite a bit.

@tstellar Once this is passing CI, I'd like to have your permission to merge this to release/12.x because this is a pretty vexing issue.

@ldionne Go ahead and merge when it's ready, and make sure to use git cherry-pick -x.

Thanks. I will make sure to include the commit that it's "cherry-picked" from in the commit message, but I can't use git cherry-pick -x as-is because there's too much divergence. I had to apply this cherry-pick manually. But it'll be cross-referenced as-if.

ldionne accepted this revision.Jun 16 2021, 10:14 AM

The remaining CI issues already exist before this patch. I'll try fixing them subsequently, but this is good to go.

This revision is now accepted and ready to land.Jun 16 2021, 10:14 AM
ldionne closed this revision.Jun 16 2021, 10:18 AM
commit e7dac564cd0ed9dee74ef972c46622743d90915d (HEAD -> release/12.x, origin/release/12.x)
Author: Louis Dionne <ldionne.2@gmail.com>
Date:   Tue Jun 15 17:55:27 2021 -0400

    [🍒][libc++] Un-deprecate std::allocator<void>

    This is a cherry-pick of 87784cc6fb3453a17e0e78 on 'main' for
    backporting to LLVM 12.

    Differential Revision: https://reviews.llvm.org/D104324