This is an archive of the discontinued LLVM Phabricator instance.

Don't link ObjCARCOpts twice. Fixes PR22543
ClosedPublic

Authored by loladiro on Jun 11 2015, 12:49 PM.

Download Raw Diff

Details

Reviewers

clayborg
sylvestre.ledru
labath

Commits

rGc847e7e54372: Don't link ObjCARCOpts twice. Fixes PR22543
rLLDB240104: Don't link ObjCARCOpts twice. Fixes PR22543
rL240104: Don't link ObjCARCOpts twice. Fixes PR22543

Summary

ObjCARCOpts is already included by ClangCodeGen. Linking it again causes the error in PR22543.

Diff Detail

Repository: rL LLVM

Event Timeline

loladiro updated this revision to Diff 27537.Jun 11 2015, 12:49 PM

loladiro retitled this revision from to Don't link ObjCARCOpts twice. Fixes PR22543.

loladiro updated this object.

loladiro edited the test plan for this revision. (Show Details)

loladiro added a reviewer: sylvestre.ledru.

loladiro set the repository for this revision to rL LLVM.

loladiro added a subscriber: Unknown Object (MLST).

While I'm at it, fix a related problem in lldb-server.

Bump. This is a minor change without which LLDB is totally unusable when built with Makefiles. Should I generally just commit these kinds of things directly? There's also D5431, which I'd like to get in.

We don't use the makefile build, but it looks pretty safe. I say just go ahead...

This revision is now accepted and ready to land.Jun 18 2015, 1:42 PM

Thank you!

Closed by commit rL240104: Don't link ObjCARCOpts twice. Fixes PR22543 (authored by kfischer). · Explain WhyJun 18 2015, 4:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Makefile

1 line

tools/

lldb-server/

Makefile

2 lines

Diff 27541

lib/Makefile

Context not available.
	clangSema.a \	clangSema.a \
	clangSerialization.a \	clangSerialization.a \
	LLVMMCDisassembler.a \	LLVMMCDisassembler.a \
	LLVMObjCARCOpts.a \
	LLVMProfileData.a \	LLVMProfileData.a \
	lldbPluginPlatformMacOSX.a \	lldbPluginPlatformMacOSX.a \
	lldbPluginPlatformLinux.a \	lldbPluginPlatformLinux.a \
Context not available.

tools/lldb-server/Makefile

Context not available.

	LLVMLibsOptions += -llldb -llldbUtility	LLVMLibsOptions += -llldb -llldbUtility

	USEDLIBS := LLVMSupport.a	LINK_COMPONENTS := support

	include $(LLDB_LEVEL)/Makefile	include $(LLDB_LEVEL)/Makefile

Context not available.