This is an archive of the discontinued LLVM Phabricator instance.

Differential D103812

[lld/mac] Add a test for -reexport_library + -dead_strip_dylibs
ClosedPublic

Authored by thakis on Jun 7 2021, 7:24 AM.

Details

Reviewers
gkm
int3
Group Reviewers
Restricted Project
Commits
rG422544414b0d: [lld/mac] Add a test for -reexport_library + -dead_strip_dylibs
Summary

Our behavior here already matched ld64, now we have a test for it.

(ld64 even strips the library here if you also pass -needed_library bar.dylib.
That seems wrong to me, and lld honors needed_library in that case.)

Diff Detail

Event Timeline

thakis created this revision.Jun 7 2021, 7:24 AM
Herald added a reviewer: gkm. · View Herald TranscriptJun 7 2021, 7:24 AM
Herald added a project: Restricted Project. · View Herald Transcript
thakis requested review of this revision.Jun 7 2021, 7:24 AM
Harbormaster completed remote builds in B107979: Diff 350285.Jun 7 2021, 8:14 AM
int3 accepted this revision.Jun 7 2021, 9:59 AM
int3 added a subscriber: int3.

Thanks!

This revision is now accepted and ready to land.Jun 7 2021, 9:59 AM
Closed by commit rG422544414b0d: [lld/mac] Add a test for -reexport_library + -dead_strip_dylibs (authored by thakis). · Explain WhyJun 7 2021, 10:45 AM
This revision was automatically updated to reflect the committed changes.
thakis added a commit: rG422544414b0d: [lld/mac] Add a test for -reexport_library + -dead_strip_dylibs.
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2021, 10:45 AM

Revision Contents

PathSize
lld/
test/
MachO/
8 lines

Diff 350358

lld/test/MachO/dead-strip-dylibs.s

Show All 40 Lines
# RUN: %lld -lSystem %t/main.o -o %t/main %t/foo.dylib %t/bar-strip.dylib # RUN: %lld -lSystem %t/main.o -o %t/main %t/foo.dylib %t/bar-strip.dylib
# RUN: llvm-otool -L %t/main | FileCheck --check-prefix=NOBARSTRIP %s # RUN: llvm-otool -L %t/main | FileCheck --check-prefix=NOBARSTRIP %s
# NOBARSTRIP-NOT: bar-strip.dylib # NOBARSTRIP-NOT: bar-strip.dylib
# NOBARSTRIP: /usr/lib/libSystem.dylib # NOBARSTRIP: /usr/lib/libSystem.dylib
# NOBARSTRIP-NOT: bar-strip.dylib # NOBARSTRIP-NOT: bar-strip.dylib
# NOBARSTRIP: foo.dylib # NOBARSTRIP: foo.dylib
# NOBARSTRIP-NOT: bar-strip.dylib # NOBARSTRIP-NOT: bar-strip.dylib
## Even libraries explicitly reexported with -reexport_library are stripped
## if they are not referenced.
# RUN: %lld -lSystem %t/main.o -o %t/main %t/foo_with_bar.dylib \
# RUN: -reexport_library %t/bar.dylib -dead_strip_dylibs
# RUN: llvm-otool -L %t/main | FileCheck --check-prefix=NOBAR %s
# RUN: llvm-otool -l %t/main | FileCheck --check-prefix=NOREEXPORT %s
# NOREEXPORT-NOT: LC_REEXPORT_DYLIB
## But -needed_library and -needed-l win over -dead_strip_dylibs again. ## But -needed_library and -needed-l win over -dead_strip_dylibs again.
# RUN: %lld -lSystem %t/main.o -o %t/main %t/foo_with_bar.dylib \ # RUN: %lld -lSystem %t/main.o -o %t/main %t/foo_with_bar.dylib \
# RUN: -needed_library %t/bar.dylib -dead_strip_dylibs # RUN: -needed_library %t/bar.dylib -dead_strip_dylibs
# RUN: llvm-otool -L %t/main | FileCheck --check-prefix=BAR %s # RUN: llvm-otool -L %t/main | FileCheck --check-prefix=BAR %s
# RUN: %lld -lSystem %t/main.o -o %t/main %t/foo_with_bar.dylib \ # RUN: %lld -lSystem %t/main.o -o %t/main %t/foo_with_bar.dylib \
# RUN: -L%t -needed-lbar -dead_strip_dylibs # RUN: -L%t -needed-lbar -dead_strip_dylibs
# RUN: llvm-otool -L %t/main | FileCheck --check-prefix=BAR %s # RUN: llvm-otool -L %t/main | FileCheck --check-prefix=BAR %s
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines