This is an archive of the discontinued LLVM Phabricator instance.

Differential D10358

[mips] Pass on -m{single,double}-float to GAS.
ClosedPublic

Authored by tomatabacu on Jun 10 2015, 6:19 AM.

Details

Reviewers
dsanders
atanasyan
Commits
rGb36d610cc226: [mips] Pass on -m{single,double}-float to GAS.
rC239525: [mips] Pass on -m{single,double}-float to GAS.
rL239525: [mips] Pass on -m{single,double}-float to GAS.
Summary

We already pass these to the IAS, but not to GAS.

Diff Detail

Event Timeline

tomatabacu updated this revision to Diff 27439.Jun 10 2015, 6:19 AM
tomatabacu retitled this revision from to [mips] Pass on -m{single,double}-float to GAS..
tomatabacu updated this object.
tomatabacu edited the test plan for this revision. (Show Details)
tomatabacu added reviewers: dsanders, atanasyan.
tomatabacu added a subscriber: Unknown Object (MLST).
atanasyan accepted this revision.Jun 10 2015, 6:28 AM
atanasyan edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jun 10 2015, 6:28 AM
tomatabacu closed this revision.Jun 11 2015, 5:17 AM
tomatabacu edited edge metadata.Jun 11 2015, 6:40 AM
tomatabacu edited subscribers, added: Unknown Object (MLST); removed: Unknown Object (MLST).

Revision Contents

PathSize
lib/
Driver/
3 lines
test/
Driver/
10 lines

Diff 27439

lib/Driver/Tools.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 7,685 Lines • ▼ Show 20 Lines if (Arg *A = Args.getLastArg(options::OPT_mmsa, options::OPT_mno_msa)) {
// support -mmsa / -mno-msa options. // support -mmsa / -mno-msa options.
if (A->getOption().matches(options::OPT_mmsa)) if (A->getOption().matches(options::OPT_mmsa))
CmdArgs.push_back(Args.MakeArgString("-mmsa")); CmdArgs.push_back(Args.MakeArgString("-mmsa"));
} }
Args.AddLastArg(CmdArgs, options::OPT_mhard_float, Args.AddLastArg(CmdArgs, options::OPT_mhard_float,
options::OPT_msoft_float); options::OPT_msoft_float);
Args.AddLastArg(CmdArgs, options::OPT_mdouble_float,
options::OPT_msingle_float);
Args.AddLastArg(CmdArgs, options::OPT_modd_spreg, Args.AddLastArg(CmdArgs, options::OPT_modd_spreg,
options::OPT_mno_odd_spreg); options::OPT_mno_odd_spreg);
NeedsKPIC = true; NeedsKPIC = true;
break; break;
} }
case llvm::Triple::systemz: { case llvm::Triple::systemz: {
// Always pass an -march option, since our default of z10 is later // Always pass an -march option, since our default of z10 is later
▲ Show 20 Lines • Show All 1,334 Lines • Show Last 20 Lines

test/Driver/mips-as.c

Show First 20 Lines • Show All 275 Lines • ▼ Show 20 Lines
// RUN: | FileCheck -check-prefix=ODDSPREG --implicit-check-not=-mno-odd-spreg %s // RUN: | FileCheck -check-prefix=ODDSPREG --implicit-check-not=-mno-odd-spreg %s
// ODDSPREG: as{{(.exe)?}}" // ODDSPREG: as{{(.exe)?}}"
// ODDSPREG: -modd-spreg // ODDSPREG: -modd-spreg
// //
// RUN: %clang -target mips-linux-gnu -### -no-integrated-as -modd-spreg -mno-odd-spreg -c %s 2>&1 \ // RUN: %clang -target mips-linux-gnu -### -no-integrated-as -modd-spreg -mno-odd-spreg -c %s 2>&1 \
// RUN: | FileCheck -check-prefix=NOODDSPREG --implicit-check-not=-modd-spreg %s // RUN: | FileCheck -check-prefix=NOODDSPREG --implicit-check-not=-modd-spreg %s
// NOODDSPREG: as{{(.exe)?}}" // NOODDSPREG: as{{(.exe)?}}"
// NOODDSPREG: -mno-odd-spreg // NOODDSPREG: -mno-odd-spreg
//
// RUN: %clang -target mips-linux-gnu -### -no-integrated-as -mdouble-float -msingle-float -c %s 2>&1 \
// RUN: | FileCheck -check-prefix=SINGLEFLOAT --implicit-check-not=-mdouble-float %s
// SINGLEFLOAT: as{{(.exe)?}}"
// SINGLEFLOAT: -msingle-float
//
// RUN: %clang -target mips-linux-gnu -### -no-integrated-as -msingle-float -mdouble-float -c %s 2>&1 \
// RUN: | FileCheck -check-prefix=DOUBLEFLOAT --implicit-check-not=-msingle-float %s
// DOUBLEFLOAT: as{{(.exe)?}}"
// DOUBLEFLOAT: -mdouble-float