Page MenuHomePhabricator

[lldb] Remove SBCommandReturnObject::ref
ClosedPublic

Authored by teemperor on Mon, May 31, 1:49 AM.

Details

Summary

This function was added in D67589 and returns an internal CommandReturnObject
which isn't allowed in the SB API. This patch just makes it private as all uses
of this function are inside SBCommandReturnObject.

Diff Detail

Event Timeline

teemperor created this revision.Mon, May 31, 1:49 AM
teemperor requested review of this revision.Mon, May 31, 1:49 AM

IIUC this was originally public but then we made the other users friends (but the public remained). But still putting this up for review in case I missed something

jankratochvil accepted this revision.Mon, May 31, 1:55 AM

I agree it should not be permitted to return the internal object from SB API. And if it still compiles after moving to private: then why not.

This revision is now accepted and ready to land.Mon, May 31, 1:55 AM
This revision was landed with ongoing or failed builds.Tue, Jun 1, 8:57 AM
This revision was automatically updated to reflect the committed changes.