This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Add UNSUPPORTED: msvc in a couple verify.cpp tests
ClosedPublic

Authored by mstorsjo on May 28 2021, 4:19 AM.

Details

Summary

Due to issues with the detection of the clang-verify feature, these
tests have been skipped in the Windows CI configuration so far.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.May 28 2021, 4:19 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 28 2021, 4:19 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 28 2021, 5:25 AM
ldionne added a subscriber: ldionne.

I'll admit I'd like it better if we could make MSVC mode match the regular Clang.

This revision is now accepted and ready to land.May 28 2021, 5:25 AM

I'll admit I'd like it better if we could make MSVC mode match the regular Clang.

Yeah I can imagine that - although it's pretty much by design, where MSVC mode differs both in how errors are printed, and how the exact language gets evaluated.