Page MenuHomePhabricator

[gn] Make ubsan errors fatal, as in cmake
ClosedPublic

Authored by rnk on Thu, May 27, 8:02 PM.

Details

Summary

Apparently ubsan errors are non-fatal by default. If you introduce UB
into LLVM and run the tests, if errors are not fatal, the test will
still produce the expected output and the tests will pass. In order to
make ubsan errors show up as test failures, they have to be made fatal.
Pass the -fno-sanitize-recover=all flag to make it so.

Diff Detail

Event Timeline

rnk requested review of this revision.Thu, May 27, 8:02 PM
rnk created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptThu, May 27, 8:02 PM
aeubanks accepted this revision.Thu, May 27, 9:03 PM
This revision is now accepted and ready to land.Thu, May 27, 9:03 PM
This revision was landed with ongoing or failed builds.Fri, May 28, 8:05 AM
This revision was automatically updated to reflect the committed changes.