This is an archive of the discontinued LLVM Phabricator instance.

Differential D10323

r231423
ClosedPublic

Authored by Eugene.Zelenko on Jun 8 2015, 3:03 PM.

Details

Reviewers
• tstellarAMD
clayborg
Summary

Remove libedit and libncurses from LLDB_SYSTEM_LIBS if they're disabled.

Diff Detail

Event Timeline

Eugene.Zelenko updated this revision to Diff 27335.Jun 8 2015, 3:03 PM
Eugene.Zelenko retitled this revision from to r231423.
Eugene.Zelenko updated this object.
Eugene.Zelenko edited the test plan for this revision. (Show Details)
Eugene.Zelenko added a reviewer: • tstellarAMD.
Eugene.Zelenko added a project: Restricted Project.
• tstellarAMD added a reviewer: clayborg.Jun 10 2015, 6:43 AM
• tstellarAMD edited edge metadata.

Hi Greg,

Is this patch OK to merge into the 3.6 stable branch?

clayborg accepted this revision.Jun 15 2015, 3:39 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jun 15 2015, 3:39 PM
• tstellarAMD closed this revision.Jun 22 2015, 9:52 AM

Revision Contents

PathSize
cmake/
7 lines

Diff 27335

cmake/LLDBDependencies.cmake

Context not available.
set(LLDB_SYSTEM_LIBS) set(LLDB_SYSTEM_LIBS)
if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows" AND NOT __ANDROID_NDK__) if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows" AND NOT __ANDROID_NDK__)
list(APPEND LLDB_SYSTEM_LIBS edit panel ncurses) if (NOT LLDB_DISABLE_LIBEDIT)
list(APPEND LLDB_SYSTEM_LIBS edit)
endif()
if (NOT LLDB_DISABLE_CURSES)
list(APPEND LLDB_SYSTEM_LIBS panel ncurses)
endif()
endif() endif()
# On FreeBSD backtrace() is provided by libexecinfo, not libc. # On FreeBSD backtrace() is provided by libexecinfo, not libc.
if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD") if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
Context not available.