This is an archive of the discontinued LLVM Phabricator instance.

Fix TestSymbolContext for remote Windows to Android.
ClosedPublic

Authored by chaoren on Jun 5 2015, 8:37 PM.

Reviewers

zturner
clayborg

Commits

Summary

Denormalize path returned by SBFileSpec::GetDirectory().

chaoren retitled this revision from to Fix TestSymbolContext for remote Windows to Android..

chaoren updated this object.

chaoren edited the test plan for this revision. (Show Details)

chaoren added a subscriber: Unknown Object (MLST).

Looks good.

This revision is now accepted and ready to land.Jun 8 2015, 3:14 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

source/

API/

9 lines

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Lines	SBFileSpec::GetFilename() const
}		}

return s;		return s;
}		}

const char *		const char *
SBFileSpec::GetDirectory() const		SBFileSpec::GetDirectory() const
{		{
const char *s = m_opaque_ap->GetDirectory().AsCString();		FileSpec directory{*m_opaque_ap};
		directory.GetFilename().Clear();
Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));		Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
if (log)		if (log)
{		{
if (s)		if (directory)
log->Printf ("SBFileSpec(%p)::GetDirectory () => \"%s\"",		log->Printf ("SBFileSpec(%p)::GetDirectory () => \"%s\"",
static_cast<void*>(m_opaque_ap.get()), s);		static_cast<void*>(m_opaque_ap.get()), directory.GetCString());
else		else
log->Printf ("SBFileSpec(%p)::GetDirectory () => NULL",		log->Printf ("SBFileSpec(%p)::GetDirectory () => NULL",
static_cast<void*>(m_opaque_ap.get()));		static_cast<void*>(m_opaque_ap.get()));
}		}
return s;		return directory.GetCString();
}		}

void		void
SBFileSpec::SetFilename(const char *filename)		SBFileSpec::SetFilename(const char *filename)
{		{
if (filename && filename[0])		if (filename && filename[0])
m_opaque_ap->GetFilename().SetCString(filename);		m_opaque_ap->GetFilename().SetCString(filename);
else		else
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines