Update TestGdbRemoteAbort and TestGdbRemoteSegFault to use `get_signal_number`.

[ovyalov]

test/functionalities/process_group/TestChangeProcessGroup.py

75 ↗

(On Diff #27237)

Since it checks for local /proc directory it's ok to send local SIGKILL.

To make it work on any platform we may use sth like

self.dbg.GetSelectedPlatform().Kill(int(pid))

instead of

if lldb.remote_platform:
               lldb.remote_platform.Kill(int(pid))
           else:
               if os.path.exists("/proc/" + pid):
                   os.kill(int(pid), lldbutil.get_signal_number('SIGKILL'))

test/lldbtest.py

297 ↗

(On Diff #27237)

_LocalProcess handles only local processes - signal.SIGHUP should be ok.

1334 ↗

(On Diff #27237)

Fork should be only local.

[chaoren]

• Only use get_signal_number where it's possible to be a remote signal.

[ovyalov]

LGTM

lldb/trunk/test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py

def inferior_abort_received(self):
             {"direction":"send", "regex":r"^\$T([0-9a-fA-F]{2}).*#[0-9a-fA-F]{2}$", "capture":{ 1:"hex_exit_code"} },
             ], True)
 
         context = self.expect_gdbremote_sequence()
         self.assertIsNotNone(context)
 
         hex_exit_code = context.get("hex_exit_code")
         self.assertIsNotNone(hex_exit_code)
-        self.assertEquals(int(hex_exit_code, 16), signal.SIGABRT)
+        self.assertEquals(int(hex_exit_code, 16),
+                          lldbutil.get_signal_number('SIGABRT'))
 
     @debugserver_test
     @dsym_test
     def test_inferior_abort_received_debugserver_dsym(self):
         self.init_debugserver_test()
         self.buildDsym()
         self.inferior_abort_received()
 
     @llgs_test
     @dwarf_test
     @skipIfTargetAndroid(api_levels=[16]) # abort() on API 16 raises SIGSEGV!
     def test_inferior_abort_received_llgs_dwarf(self):
         self.init_llgs_test()
         self.buildDwarf()
         self.inferior_abort_received()
 

lldb/trunk/test/tools/lldb-server/inferior-crash/TestGdbRemoteSegFault.py

def test_inferior_seg_fault_received_debugserver_dsym(self):
         self.buildDsym()
         self.inferior_seg_fault_received(self.GDB_REMOTE_STOP_CODE_BAD_ACCESS)
 
     @llgs_test
     @dwarf_test
     def test_inferior_seg_fault_received_llgs_dwarf(self):
         self.init_llgs_test()
         self.buildDwarf()
-        self.inferior_seg_fault_received(signal.SIGSEGV)
+        self.inferior_seg_fault_received(lldbutil.get_signal_number('SIGSEGV'))