Unique file names for TestStarted and TestFinished.

[chaoren]

Summary

This fixes the issue of multiple test suites opening the same file for writing.

[zturner]

This seems suspicious to me. Why are 2 different instances of dotest.py
running in different processes both trying to run the same test?

[chaoren]

Why are 2 different instances of dotest.py running in different processes both trying to run the same test?

They're not. But all test suites write to the same TestStarted and TestFinished.

[zturner]

Oh ok, that makes sense then. Would it be better to use the filename
instead of the pid? I guess it doesn't matter because nobody really looks
at those files anyway, they're just for bookkeeping for the test suite. So
lgtm, up to you if you want to use filename or pid.

[chaoren]

There might not be a filename.

[chaoren]

Or you could have the same file name but in different search directories.

test/dotest.py

 
 if not os.path.isdir(sdir_name):
     try:
         os.mkdir(sdir_name)
     except OSError as exception:
         if exception.errno != errno.EEXIST:
             raise
 where_to_save_session = os.getcwd()
-fname = os.path.join(sdir_name, "TestStarted")
+fname = os.path.join(sdir_name, "TestStarted-%d" % os.getpid())
 with open(fname, "w") as f:
     print >> f, "Test started at: %s\n" % timestamp_started
     print >> f, svn_info
     print >> f, "Command invoked: %s\n" % getMyCommandLine()
 
 #
 # Invoke the default TextTestRunner to run the test suite, possibly iterating
 # over different configurations.
sys.stderr.write("Session logs for test failures/errors/unexpected successes"
                      " can be found in directory '%s'\n" % sdir_name)
 
 if useCategories and len(failuresPerCategory) > 0:
     sys.stderr.write("Failures per category:\n")
     for category in failuresPerCategory:
         sys.stderr.write("%s - %d\n" % (category,failuresPerCategory[category]))
 
 os.chdir(where_to_save_session)
-fname = os.path.join(sdir_name, "TestFinished")
+fname = os.path.join(sdir_name, "TestFinished-%d" % os.getpid())
 with open(fname, "w") as f:
     print >> f, "Test finished at: %s\n" % datetime.datetime.now().strftime("%Y-%m-%d-%H_%M_%S")
 
 # Terminate the test suite if ${LLDB_TESTSUITE_FORCE_FINISH} is defined.
 # This should not be necessary now.
 if ("LLDB_TESTSUITE_FORCE_FINISH" in os.environ):
     print "Terminating Test suite..."
     subprocess.Popen(["/bin/sh", "-c", "kill %s; exit 0" % (os.getpid())])
 
 # Exiting.
 exitTestSuite(failed)