This is an archive of the discontinued LLVM Phabricator instance.

Differential D102807

Revert "[AIX] Avoid structor alias; die before bad alias codegen"
AbandonedPublic

Authored by Jake-Egan on May 19 2021, 1:55 PM.

Details

Reviewers
None
Summary

This reverts commit b116ded57da3530e661f871f4191c59cd9e091cd.

Diff Detail

Event Timeline

Jake-Egan created this revision.May 19 2021, 1:55 PM
Herald added a subscriber: jeroen.dobbelaere. · View Herald TranscriptMay 19 2021, 1:55 PM
Jake-Egan requested review of this revision.May 19 2021, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2021, 1:55 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Jake-Egan abandoned this revision.May 19 2021, 2:04 PM

Duplicate.

Harbormaster completed remote builds in B105303: Diff 346558.May 19 2021, 2:30 PM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
6 lines
test/
Driver/
4 lines

Diff 346558

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,967 Lines • ▼ Show 20 Lines#endif
} }
if (Args.hasArg(options::OPT_fdebug_pass_arguments)) { if (Args.hasArg(options::OPT_fdebug_pass_arguments)) {
CmdArgs.push_back("-mdebug-pass"); CmdArgs.push_back("-mdebug-pass");
CmdArgs.push_back("Arguments"); CmdArgs.push_back("Arguments");
} }
// Enable -mconstructor-aliases except on darwin, where we have to work around // Enable -mconstructor-aliases except on darwin, where we have to work around
// a linker bug (see <rdar://problem/7651567>), and CUDA/AMDGPU device code, // a linker bug (see <rdar://problem/7651567>), and CUDA/AMDGPU device code,
// where aliases aren't supported. Similarly, aliases aren't yet supported // where aliases aren't supported.
// for AIX. if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && !RawTriple.isAMDGPU())
if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() &&
!RawTriple.isAMDGPU() && !RawTriple.isOSAIX())
CmdArgs.push_back("-mconstructor-aliases"); CmdArgs.push_back("-mconstructor-aliases");
// Darwin's kernel doesn't support guard variables; just die if we // Darwin's kernel doesn't support guard variables; just die if we
// try to use them. // try to use them.
if (KernelOrKext && RawTriple.isOSDarwin()) if (KernelOrKext && RawTriple.isOSDarwin())
CmdArgs.push_back("-fforbid-guard-variables"); CmdArgs.push_back("-fforbid-guard-variables");
if (Args.hasFlag(options::OPT_mms_bitfields, options::OPT_mno_ms_bitfields, if (Args.hasFlag(options::OPT_mms_bitfields, options::OPT_mno_ms_bitfields,
▲ Show 20 Lines • Show All 2,699 Lines • Show Last 20 Lines

clang/test/Driver/aix-constructor-alias.c

// Check that we don't pass -mconstructor-aliases when compiling for AIX. // Check that we pass -mconstructor-aliases when compiling for AIX.
// RUN: %clang -### -target powerpc-ibm-aix7.1.0.0 %s -c -o %t.o 2>&1 \ // RUN: %clang -### -target powerpc-ibm-aix7.1.0.0 %s -c -o %t.o 2>&1 \
// RUN: | FileCheck %s // RUN: | FileCheck %s
// RUN: %clang -### -target powerpc64-ibm-aix7.1.0.0 %s -c -o %t.o 2>&1 \ // RUN: %clang -### -target powerpc64-ibm-aix7.1.0.0 %s -c -o %t.o 2>&1 \
// RUN: | FileCheck %s // RUN: | FileCheck %s
// CHECK-NOT: "-mconstructor-aliases" // CHECK: "-mconstructor-aliases"