This fixs the bug
I have done arc commit --revision D<Revision> in my local svn repository and it seems to be successful, did I miss some thing?
If it does not get committed, please commit it for me, thanks.
I tried to add a test for this while committing it, and it doesn't pass for me. I think this needs more work. Your 'NoArgumentUnused' flag suppresses the warning message without actually passing -r to the linker.
What is your test case?
I followed the bug https://llvm.org/bugs/show_bug.cgi?id=12587
Before my change, the output of 'file all.o' is
all.o: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, not stripped
After this change, the output is
all.o: ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped
So I think this patch is working.