This is an archive of the discontinued LLVM Phabricator instance.

Add control flow integrity diagnosis function to UBSan runtime library.
ClosedPublic

Authored by pcc on Jun 4 2015, 7:52 PM.

Diff Detail

Event Timeline

pcc updated this revision to Diff 27172.Jun 4 2015, 7:52 PM
pcc retitled this revision from to Add control flow integrity diagnosis function to UBSan runtime library. Also includes execution tests for the feature..
pcc updated this object.
pcc edited the test plan for this revision. (Show Details)
pcc added a reviewer: rsmith.
pcc added a subscriber: Unknown Object (MLST).
pcc updated this revision to Diff 27979.Jun 18 2015, 5:24 PM
pcc retitled this revision from Add control flow integrity diagnosis function to UBSan runtime library. Also includes execution tests for the feature. to Add control flow integrity diagnosis function to UBSan runtime library..
pcc updated this object.

Refresh

samsonov accepted this revision.Jun 18 2015, 5:51 PM
samsonov edited edge metadata.

LGTM

test/cfi/lit.cfg
12 ↗(On Diff #27979)

I think it would be easier to construct list of args for clangxx_cfi, and clangxx_cfi_diag, and then do ' '.join(...) for both of them. Leaving this up to you, though.

This revision is now accepted and ready to land.Jun 18 2015, 5:51 PM
This revision was automatically updated to reflect the committed changes.