Page MenuHomePhabricator

[lldb][NFC] Remove misleading ModulePass base class for IRForTarget
ClosedPublic

Authored by teemperor on Tue, May 18, 2:59 AM.

Details

Summary

IRForTarget is never used by a pass manager or any other interface that requires this class to inherit from Pass.

Also IRForTarget doesn't implement the current interface correctly because it uses the runOnModule return value to indicate success/failure instead of changed/not-changed, so if this ever ends up being used as a pass it would most likely not work as intended.

Diff Detail

Event Timeline

teemperor requested review of this revision.Tue, May 18, 2:59 AM
teemperor created this revision.
This revision is now accepted and ready to land.Wed, May 19, 10:19 AM
This revision was landed with ongoing or failed builds.Tue, May 25, 4:27 AM
This revision was automatically updated to reflect the committed changes.