Page MenuHomePhabricator

Fix to the interrupt timeout handling: reset the timeout on re-entry
ClosedPublic

Authored by jingham on May 15 2021, 3:05 PM.

Details

Summary

The new timeout handling missed one case where we need to reset the computed timeout: when a packet interrupts the Continue wait, but asks to re-enter the wait loop when done.

This is the only other way to get back to the ReadPacket call, so this is the only other place that requires reset.

Diff Detail

Event Timeline

jingham requested review of this revision.May 15 2021, 3:05 PM
jingham created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2021, 3:05 PM
clayborg accepted this revision.May 15 2021, 3:10 PM
This revision is now accepted and ready to land.May 15 2021, 3:10 PM
jingham updated this revision to Diff 345654.May 15 2021, 3:44 PM

It's less error-prone if we just reset the timeout to the default when we wake up from ReadPacket. This isn't an expensive operation...

This revision was landed with ongoing or failed builds.May 17 2021, 10:49 AM
This revision was automatically updated to reflect the committed changes.