Page MenuHomePhabricator

[libcxxabi] Remove unnecessary define from build
ClosedPublic

Authored by smeenai on May 12 2021, 2:49 PM.

Details

Reviewers
phosek
Group Reviewers
Restricted Project
Commits
rG6c05f2dab384: [libcxxabi] Remove unnecessary define from build
Summary

Now that we're passing -D_LIBCPP_BUILDING_LIBRARY to the libc++abi
build, -D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS is redundant
(https://github.com/llvm/llvm-project/blob/fb3a00c327df78eaa534e53ac6f07112e0585121/libcxx/include/exception#L120-L121
is the only use of _LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS in
libc++, and that conditional also checks for _LIBCPP_BUILDING_LIBRARY).

Diff Detail

Event Timeline

smeenai created this revision.May 12 2021, 2:49 PM
smeenai requested review of this revision.May 12 2021, 2:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2021, 2:49 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
phosek accepted this revision.May 19 2021, 9:40 AM
phosek added a subscriber: phosek.

LGTM

This revision is now accepted and ready to land.May 19 2021, 9:40 AM
smeenai updated this revision to Diff 346514.May 19 2021, 11:07 AM

Rebasing to see if tests are happier

This revision was landed with ongoing or failed builds.May 20 2021, 4:56 PM
This revision was automatically updated to reflect the committed changes.