This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove some more unnecessary _VSTD::. NFCI.
ClosedPublic

Authored by Quuxplusone on May 10 2021, 10:23 AM.

Details

Summary

Inspired by D102133, do some more cosmetic search-and-replace.
Notice there are a few places (not modified in this diff) where we have, like, chrono::weekday weekday() const or _VSTD::wstring wstring() const — a member function with the same name as a type — and in those cases we have to continue qualifying the name in order to make name lookup do the right thing.

Diff Detail

Event Timeline

Quuxplusone requested review of this revision.May 10 2021, 10:23 AM
Quuxplusone created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMay 10 2021, 10:23 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 11 2021, 9:25 AM
This revision was automatically updated to reflect the committed changes.

Interesting to see you even found some uses of std::.
LGTM!

libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/params.fail.cpp
27 ↗(On Diff #344260)

Nice catch!