As a GSoC project last year, I'm sending the initial diff to support FreeBSD kernel debugging for review.
Diff generated using git diff -U999999 upstream/master on my gsoc branch here https://github.com/cosql/lldb/tree/gsoc.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Note that the LLDB coding style has been updated to match LLVM's in general, with a few differences remaining. The main take-away is that the space before paren on functions can go away.
http://lldb.llvm.org/lldb-coding-conventions.html
http://llvm.org/docs/CodingStandards.html
source/API/SystemInitializerFull.cpp | ||
---|---|---|
1 | whitespace |
Comment Actions
I honestly feel bad because this sit there for a long time without anybody reviewing it.
I tried but after some time looking at it I realized I'm not the right person to review. I cc:ed clayborg -- maybe he can take a look at this.
Comment Actions
Looks good as long as the code is using the LLDB coding style which I believe has been addressed.
whitespace