This is an archive of the discontinued LLVM Phabricator instance.

Differential D10194

Use wildcard instead of relying on shell globbing.
ClosedPublic

Authored by chaoren on Jun 2 2015, 12:05 PM.

Details

Reviewers
zturner
clayborg
Commits
rGc168c92b783b: Use wildcard instead of relying on shell globbing.
rLLDB238859: Use wildcard instead of relying on shell globbing.
rL238859: Use wildcard instead of relying on shell globbing.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren updated this revision to Diff 26997.Jun 2 2015, 12:05 PM
chaoren retitled this revision from to Use wildcard instead of relying on shell globbing..
chaoren updated this object.
chaoren edited the test plan for this revision. (Show Details)
chaoren added reviewers: zturner, clayborg.
chaoren added a subscriber: Unknown Object (MLST).
zturner edited edge metadata.Jun 2 2015, 12:10 PM

lgtm, thanks. I fixed a few of these already but I guess there's still
more.

Closed by commit rL238859: Use wildcard instead of relying on shell globbing. (authored by chaoren). · Explain WhyJun 2 2015, 12:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
test/
expression_command/
call-function/
2 lines
functionalities/
data-formatter/
rdar-12437442/
3 lines

Diff 26999

lldb/trunk/test/expression_command/call-function/Makefile

LEVEL = ../../make LEVEL = ../../make
CXX_SOURCES := main.cpp CXX_SOURCES := main.cpp
# clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD # clang-3.5+ outputs FullDebugInfo by default for Darwin/FreeBSD
# targets. Other targets do not, which causes this test to fail. # targets. Other targets do not, which causes this test to fail.
# This flag enables FullDebugInfo for all targets. # This flag enables FullDebugInfo for all targets.
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CFLAGS_EXTRAS += -fno-limit-debug-info CFLAGS_EXTRAS += -fno-limit-debug-info
endif endif
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
clean:: clean::
rm -rf *.o *.d *.dSYM rm -rf $(wildcard *.o *.d *.dSYM)

lldb/trunk/test/functionalities/data-formatter/rdar-12437442/Makefile

LEVEL = ../../../make LEVEL = ../../../make
OBJC_SOURCES := main.m OBJC_SOURCES := main.m
CFLAGS_EXTRAS += -w CFLAGS_EXTRAS += -w
include $(LEVEL)/Makefile.rules include $(LEVEL)/Makefile.rules
LDFLAGS += -framework Foundation LDFLAGS += -framework Foundation
clean:: clean::
rm -rf *.o *.d *.dSYM *.log rm -rf $(wildcard *.o *.d *.dSYM *.log)
No newline at end of file