This is an archive of the discontinued LLVM Phabricator instance.

Differential D101867

[clang][test] Update -fc++-abi tests
ClosedPublic

Authored by leonardchan on May 4 2021, 3:38 PM.

Details

Reviewers
echristo
Commits
rG0277a24f4bba: [clang][test] Update -fc++-abi tests
Summary

This attempts to move driver tests out of Frontend and to Driver, separates RUNs that should fail from RUNs that should succeed, and prevent creating output files or dumping output.

Diff Detail

Event Timeline

leonardchan created this revision.May 4 2021, 3:38 PM
Herald added a subscriber: phosek. · View Herald TranscriptMay 4 2021, 3:38 PM
leonardchan requested review of this revision.May 4 2021, 3:38 PM
echristo added a comment.May 4 2021, 3:42 PM

Couple cleanups, but should be better now. Thanks!

-eric

clang/test/Driver/cxx-abi-flag.cpp
4

This is typically done via 2>&1 rather than |&.

clang/test/Frontend/valid-cxx-abi.cpp
3

I'd add a -S -o - to each of these command lines.

leonardchan edited the summary of this revision. (Show Details)May 4 2021, 3:42 PM
leonardchan updated this revision to Diff 342889.May 4 2021, 3:47 PM
leonardchan marked 2 inline comments as done.
leonardchan updated this revision to Diff 342891.May 4 2021, 3:50 PM

Forgot the pipe in cxx-abi-flag.cpp

echristo accepted this revision.May 4 2021, 3:51 PM
This revision is now accepted and ready to land.May 4 2021, 3:51 PM
This revision was landed with ongoing or failed builds.May 4 2021, 3:53 PM
Closed by commit rG0277a24f4bba: [clang][test] Update -fc++-abi tests (authored by leonardchan). · Explain Why
This revision was automatically updated to reflect the committed changes.
leonardchan added a commit: rG0277a24f4bba: [clang][test] Update -fc++-abi tests.
Harbormaster completed remote builds in B102631: Diff 342891.May 4 2021, 4:25 PM

Revision Contents

PathSize
clang/
test/
Driver/
11 lines
Frontend/
23 lines
4 lines

Diff 342892

clang/test/Driver/cxx-abi-flag.cpp

  • This file was added.
// Ensure that the driver flag is propagated to cc1.
// RUN: %clang -### -fc++-abi=itanium -target x86_64-unknown-linux-gnu %s \
// RUN: 2>&1 | FileCheck %s -check-prefix=ITANIUM
// RUN: %clang -### -fc++-abi=fuchsia -target x86_64-unknown-fuchsia %s \
echristoUnsubmitted
Done
ReplyInline Actions

This is typically done via 2>&1 rather than |&.

echristo: This is typically done via 2>&1 rather than |&.
// RUN: 2>&1 | FileCheck %s -check-prefix=FUCHSIA
// RUN: %clang -### -fc++-abi=microsoft -target x86_64-unknown-windows-msvc %s \
// RUN: 2>&1 | FileCheck %s -check-prefix=MICROSOFT
//
// ITANIUM: -fc++-abi=itanium
// FUCHSIA: -fc++-abi=fuchsia
// MICROSOFT: -fc++-abi=microsoft

clang/test/Frontend/invalid-cxx-abi.cpp

// REQUIRES: x86-registered-target // These shouldn't be valid -fc++-abi values.
// RUN: not %clang_cc1 -S -emit-llvm -o /dev/null -fc++-abi=InvalidABI %s 2>&1 | FileCheck %s -check-prefix=INVALID
// These should succeed. // RUN: not %clang_cc1 -S -emit-llvm -o /dev/null -fc++-abi=Fuchsia %s 2>&1 | FileCheck %s -check-prefix=CASE-SENSITIVE
// RUN: %clang -c -fc++-abi=itanium -target x86_64-unknown-linux-gnu %s
// RUN: %clang -c -fc++-abi=fuchsia -target x86_64-unknown-fuchsia %s
// RUN: %clang -c -fc++-abi=microsoft -target x86_64-windows-msvc %s
// RUN: %clang_cc1 -fc++-abi=itanium -triple x86_64-unknown-linux-gnu %s
// RUN: %clang_cc1 -fc++-abi=fuchsia -triple x86_64-unknown-fuchsia %s
// RUN: %clang_cc1 -fc++-abi=microsoft -triple x86_64-windows-msvc %s
// RUN: not %clang -c -fc++-abi=InvalidABI %s 2>&1 | FileCheck %s -check-prefix=INVALID
// RUN: not %clang -c -fc++-abi=Fuchsia %s 2>&1 | FileCheck %s -check-prefix=CASE-SENSITIVE
// RUN: not %clang_cc1 -fc++-abi=InvalidABI %s 2>&1 | FileCheck %s -check-prefix=INVALID
// RUN: not %clang_cc1 -fc++-abi=Fuchsia %s 2>&1 | FileCheck %s -check-prefix=CASE-SENSITIVE
// INVALID: error: Invalid C++ ABI name 'InvalidABI' // INVALID: error: Invalid C++ ABI name 'InvalidABI'
// CASE-SENSITIVE: error: Invalid C++ ABI name 'Fuchsia' // CASE-SENSITIVE: error: Invalid C++ ABI name 'Fuchsia'
// The flag is propgated from the driver to cc1.
// RUN: %clang -fc++-abi=InvalidABI %s -### 2>&1 | FileCheck %s -check-prefix=CC1-FLAG
// CC1-FLAG: -fc++-abi=InvalidABI
// Some C++ ABIs are not supported on some platforms. // Some C++ ABIs are not supported on some platforms.
// RUN: not %clang_cc1 -c -fc++-abi=fuchsia -triple i386 %s 2>&1 | FileCheck %s -check-prefix=UNSUPPORTED-FUCHSIA // RUN: not %clang_cc1 -S -emit-llvm -o /dev/null -fc++-abi=fuchsia -triple i386 %s 2>&1 | FileCheck %s -check-prefix=UNSUPPORTED-FUCHSIA
// UNSUPPORTED-FUCHSIA: error: C++ ABI 'fuchsia' is not supported on target triple 'i386' // UNSUPPORTED-FUCHSIA: error: C++ ABI 'fuchsia' is not supported on target triple 'i386'

clang/test/Frontend/valid-cxx-abi.cpp

  • This file was added.
// These should be valid cxx abi flags for these targets.
// RUN: %clang_cc1 -fc++-abi=itanium -triple x86_64-unknown-linux-gnu %s -S -emit-llvm -o /dev/null
// RUN: %clang_cc1 -fc++-abi=fuchsia -triple x86_64-unknown-fuchsia %s -S -emit-llvm -o /dev/null
echristoUnsubmitted
Done
ReplyInline Actions

I'd add a -S -o - to each of these command lines.

echristo: I'd add a -S -o - to each of these command lines.
// RUN: %clang_cc1 -fc++-abi=microsoft -triple x86_64-windows-msvc %s -S -emit-llvm -o /dev/null