Page MenuHomePhabricator

Thread safety analysis: Eliminate parameter from intersectAndWarn (NFC)
ClosedPublic

Authored by aaronpuchert on May 3 2021, 5:06 AM.

Details

Summary

We were modifying precisely when intersecting the lock sets of multiple
predecessors without back edge. That's no coincidence: we can't modify
on back edges, it doesn't make sense to modify at the end of a function,
and otherwise we always want to intersect on forward edges, because we
can build a new lock set for those.

Diff Detail

Event Timeline

aaronpuchert requested review of this revision.May 3 2021, 5:06 AM
aaronpuchert created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2021, 5:06 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision is now accepted and ready to land.May 4 2021, 9:06 AM