Added utility function to get correct signal number from remote platform.

[chaoren]

Summary

This change adds a utility that uses the kill -l command to get the
correct signal number. Falls back to using SBUnixSignals, and finally
signal.SIG<signal> if all else fails.

[clayborg]

Looks good.

[ovyalov]

test/lldbutil.py

934 ↗

(On Diff #26932)

Nit: to avoid nesting - if not lldb.remote_platform return getattr(signal, signal_name)

937 ↗

(On Diff #26932)

Could you check for return error value?

[chaoren]

test/lldbutil.py

934 ↗

(On Diff #26932)

I want to use getattr(signal, signal_name) as a fallback if kill -l can't find anything. Actually, it'd be better if we can check for a valid remote process first and try getting a signal value from that before falling back to getattr.

[ovyalov]

test/lldbutil.py

934 ↗

(On Diff #26932)

Yep - fallback to process instance if presented is a good option - e.g., in this case remote test invocation Linux->OSX should pass well.

[chaoren]

• Address review comments.

[ovyalov]

test/lldbutil.py

956 ↗

(On Diff #26944)

target.GetProcess() ?

[chaoren]

Whoops.

[chaoren]

Typo.

[ovyalov]

LGTM

lldb/trunk/test/lldbutil.py

 def join_remote_paths(*paths):
     # TODO: update with actual platform name for remote windows once it exists
     if lldb.remote_platform.GetName() == 'remote-windows':
         return os.path.join(*paths).replace(os.path.sep, '\\')
     return os.path.join(*paths).replace(os.path.sep, '/')
 
 def append_to_remote_wd(*paths):
     return join_remote_paths(lldb.remote_platform.GetWorkingDirectory(), *paths)
+
+# ==================================================
+# Utility functions to get the correct signal number
+# ==================================================
+
+import signal
+
+def get_signal_number(signal_name):
+    platform = lldb.remote_platform
+    if platform:
+        if platform.GetName() == 'remote-linux':
+            command = lldb.SBPlatformShellCommand('kill -l %d' % signal_name)
+            if platform.Run(command).Success() and command.GetStatus() == 0:
+                try:
+                    return int(command.GetOutput())
+                except ValueError:
+                    pass
+        elif platform.GetName() == 'remote-android':
+            for signal_number in range(1, 65):
+                command = lldb.SBPlatformShellCommand('kill -l %d' % signal_number)
+                if platform.Run(command).Fail() or command.GetStatus() != 0:
+                    continue
+                output = command.GetOutput().strip().upper()
+                if not output.startswith('SIG'):
+                    output = 'SIG' + output
+                if output == signal_name:
+                    return signal_number
+    for target_index in range(lldb.debugger.GetNumTargets()):
+        target = lldb.debugger.GetTargetAtIndex(target_index)
+        if not target.IsValid():
+            continue
+        process = target.GetProcess()
+        if not process.IsValid():
+            continue
+        signals = process.GetUnixSignals()
+        if not signals.IsValid():
+            continue
+        signal_number = signals.GetSignalNumberFromName(signal_name)
+        if signal_number > 0:
+            return signal_number
+    return getattr(signal, signal_name)