Page MenuHomePhabricator

[LLD] [COFF] Actually include the exported comdat symbols
ClosedPublic

Authored by mstorsjo on Apr 30 2021, 5:17 AM.

Details

Summary

This is a followup to 2b01a417d7ccb001ccc1185ef5fdc967c9fac8d7;
previously the RVAs of the exported symbols from comdats were left
zero.

Thanks to Kleis Auke Wolthuizen for the fix suggestion and pointing
out the omission.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Apr 30 2021, 5:17 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2021, 5:17 AM
mati865 accepted this revision.Apr 30 2021, 5:08 PM

The change itself looks correct but cannot speak for the test.

This revision is now accepted and ready to land.Apr 30 2021, 5:08 PM
rnk accepted this revision.May 4 2021, 11:24 AM

lgtm