Page MenuHomePhabricator

[libc++] [test] Don't assume iterators are class types.
ClosedPublic

Authored by Quuxplusone on Apr 27 2021, 6:33 PM.

Details

Summary
In particular, `span<int>::iterator` may be a raw pointer type
and thus have no nested typedef `iterator::value_type`. However,
we already know that the value_type we expect for `span<int>` is just `int`.
Fix up all other iterator_concept_conformance tests in the same way.

Diff Detail

Event Timeline

Quuxplusone requested review of this revision.Apr 27 2021, 6:33 PM
Quuxplusone created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptApr 27 2021, 6:33 PM
curdeius accepted this revision as: curdeius.Apr 28 2021, 1:25 AM
curdeius added a subscriber: curdeius.

FWIW, LGTM.

Quuxplusone accepted this revision.Apr 28 2021, 7:10 AM
This revision is now accepted and ready to land.Apr 28 2021, 7:10 AM