This is an archive of the discontinued LLVM Phabricator instance.

tsan: fix build with COMPILER_RT_TSAN_DEBUG_OUTPUT
ClosedPublic

Authored by dvyukov on Apr 27 2021, 11:23 AM.

Details

Summary

COMPILER_RT_TSAN_DEBUG_OUTPUT enables TSAN_COLLECT_STATS,
which changes layout of runtime structs (some structs contain
stats when the option is enabled).
It's not OK to build runtime with the define, but tests without it.
The error is detected by build_consistency_stats/nostats.
Fix this by defining TSAN_COLLECT_STATS for tests to match the runtime.

Diff Detail

Event Timeline

dvyukov created this revision.Apr 27 2021, 11:23 AM
dvyukov requested review of this revision.Apr 27 2021, 11:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2021, 11:23 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka accepted this revision.Apr 27 2021, 1:37 PM
This revision is now accepted and ready to land.Apr 27 2021, 1:37 PM
This revision was landed with ongoing or failed builds.Apr 27 2021, 1:39 PM
This revision was automatically updated to reflect the committed changes.