This is an archive of the discontinued LLVM Phabricator instance.

[lldb][WIP-ish] Add a assertPacketResponse utility to lldb-server tests
Needs ReviewPublic

Authored by labath on Apr 21 2021, 8:27 AM.

Details

Reviewers
mgorny
Summary

The goal is to replace the awkward add_log_lines dance.

Diff Detail

Event Timeline

labath requested review of this revision.Apr 21 2021, 8:27 AM
labath created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2021, 8:27 AM

I was going to wait until this is fully functional, but since you're about to
write some lldb-server tests, I figured it's a good time to get some feedback.

The main part that's missing is the ability to wait for some output to be
produced. I'd like to replace that with something completely different as the
current mechanism relies on sleeps.

But if you find it useful in the current form, I could clean it up and check in pretty quickly.