This is an archive of the discontinued LLVM Phabricator instance.

Address reviewer comments
AbandonedPublic

Authored by kimanh on Apr 19 2021, 7:00 AM.

Details

Reviewers
None
Summary

Addressing reviewer comments:

  • adding test on the header length, which changed test set
  • removing accidentally added line in test
  • removing obsolete comment
  • update error messages to start with lower letter, and no new line

Diff Detail

Event Timeline

kimanh created this revision.Apr 19 2021, 7:00 AM
kimanh requested review of this revision.Apr 19 2021, 7:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2021, 7:00 AM
kimanh abandoned this revision.Apr 19 2021, 7:01 AM

Accidentally created new revision. Closing.

llvm/test/tools/llvm-dwp/X86/invalid_cu_header_length.s