This is an archive of the discontinued LLVM Phabricator instance.

Differential D100700

[Sanitizers][TSAN] Mac M1/iOs setjmp wrapper frame pointer/link register registers renaming
Needs ReviewPublic

Authored by devnexen on Apr 17 2021, 4:06 AM.

Details

Reviewers
yln
Summary

setjmp wrappers, use fp/lr naming instead of x29/x30 registers proposal.

Diff Detail

Event Timeline

devnexen requested review of this revision.Apr 17 2021, 4:06 AM
devnexen created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2021, 4:06 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B99308: Diff 338289.Apr 17 2021, 5:05 AM
yln added a comment.Apr 19 2021, 11:50 AM

Hi David, can you explain the motivation and mechanics of this change? I see that we #define aliases for registers, but they are never used?!

devnexen added a comment.Apr 20 2021, 6:50 AM
In D100700#2699281, @yln wrote:

Hi David, can you explain the motivation and mechanics of this change? I see that we #define aliases for registers, but they are never used?!

Lines 45 for example

yln added a comment.Apr 20 2021, 11:20 AM

So the adoption of these names will be done in a separate patch? What is the motivation for this change?

devnexen added a comment.Apr 21 2021, 10:42 AM

well x29 and x30 registers are already used in fact ?

Revision Contents

PathSize
compiler-rt/
lib/
tsan/
rtl/
2 lines

Diff 338289

compiler-rt/lib/tsan/rtl/tsan_rtl_aarch64.S

Show All 24 Lines
.long 0 .long 0
#endif #endif
#if !defined(__APPLE__) #if !defined(__APPLE__)
.section .text .section .text
#else #else
.section __TEXT,__text .section __TEXT,__text
.align 3 .align 3
#define x29 fp
#define x30 lr
#endif #endif
ASM_HIDDEN(__tsan_setjmp) ASM_HIDDEN(__tsan_setjmp)
.comm _ZN14__interception11real_setjmpE,8,8 .comm _ZN14__interception11real_setjmpE,8,8
.globl ASM_SYMBOL_INTERCEPTOR(setjmp) .globl ASM_SYMBOL_INTERCEPTOR(setjmp)
ASM_TYPE_FUNCTION(ASM_SYMBOL_INTERCEPTOR(setjmp)) ASM_TYPE_FUNCTION(ASM_SYMBOL_INTERCEPTOR(setjmp))
ASM_SYMBOL_INTERCEPTOR(setjmp): ASM_SYMBOL_INTERCEPTOR(setjmp):
CFI_STARTPROC CFI_STARTPROC
▲ Show 20 Lines • Show All 91 Lines • Show Last 20 Lines