[AST] Remove args from LocationCall

[steveire]

Summary

This class initially had args to be generic to future needs. In
particular, I thought that source location introspection should show the
getBeginLoc of CallExpr args and the getArgLoc of
TemplateSpecializationLocInfo etc. However, that is probably best left
out of source location introspection because it involves node traversal.

If something like this is needed in the future, it can be added in the future.

clang/include/clang/Tooling/NodeIntrospection.h

 using SharedLocationCall = llvm::IntrusiveRefCntPtr<LocationCall>;
 
 class LocationCall : public llvm::ThreadSafeRefCountedBase<LocationCall> {
 public:
   enum LocationCallFlags { NoFlags, ReturnsPointer, IsCast };
   LocationCall(SharedLocationCall on, std::string name,
                LocationCallFlags flags = NoFlags)
       : m_flags(flags), m_on(std::move(on)), m_name(std::move(name)) {}
-  LocationCall(SharedLocationCall on, std::string name,
-               std::vector<std::string> args, LocationCallFlags flags = NoFlags)
-      : m_flags(flags), m_on(std::move(on)), m_name(std::move(name)),
-        m_args(std::move(args)) {}
 
   LocationCall *on() const { return m_on.get(); }
   StringRef name() const { return m_name; }
-  ArrayRef<std::string> args() const { return m_args; }
   bool returnsPointer() const { return m_flags & ReturnsPointer; }
   bool isCast() const { return m_flags & IsCast; }
 
 private:
   LocationCallFlags m_flags;
   SharedLocationCall m_on;
   std::string m_name;
-  std::vector<std::string> m_args;
 };
 
 class LocationCallFormatterCpp {
 public:
   static void print(const LocationCall &Call, llvm::raw_ostream &OS);
   static std::string format(const LocationCall &Call);
 };
 

clang/lib/Tooling/NodeIntrospection.cpp

void LocationCallFormatterCpp::print(const LocationCall &Call,
   if (const LocationCall *On = Call.on()) {
     print(*On, OS);
     if (On->returnsPointer())
       OS << "->";
     else
       OS << '.';
   }
 
-  OS << Call.name();
-  if (Call.args().empty()) {
-    OS << "()";
-    return;
-  }
-  OS << '(' << Call.args().front();
-  for (const std::string &Arg : Call.args().drop_front()) {
-    OS << ", " << Arg;
-  }
-  OS << ')';
+  OS << Call.name() << "()";
 }
 
 std::string LocationCallFormatterCpp::format(const LocationCall &Call) {
   std::string Result;
   llvm::raw_string_ostream OS(Result);
   print(Call, OS);
   OS.flush();
   return Result;

clang/unittests/Introspection/IntrospectionTest.cpp

if (Call.isCast()) {
       if (const LocationCall *On = Call.on())
         print(*On, OS);
       return;
     }
     if (const LocationCall *On = Call.on()) {
       print(*On, OS);
       OS << '.';
     }
-    OS << Call.name();
-    if (Call.args().empty()) {
-      OS << "()";
-      return;
-    }
-    OS << '(' << Call.args().front();
-    for (const std::string &Arg : Call.args().drop_front()) {
-      OS << ", " << Arg;
-    }
-    OS << ')';
+    OS << Call.name() << "()";
   }
 
   static std::string format(const LocationCall &Call) {
     std::string Result;
     llvm::raw_string_ostream OS(Result);
     print(Call, OS);
     OS.flush();
     return Result;