This is an archive of the discontinued LLVM Phabricator instance.

[AST] Fix location call storage with common last-invocation
ClosedPublic

Authored by steveire on Apr 15 2021, 4:30 AM.

Details

Summary

Also fix the formatter to use the front element of a chained call
instead of the back element.

Diff Detail

Event Timeline

steveire requested review of this revision.Apr 15 2021, 4:30 AM
steveire created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2021, 4:30 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
njames93 accepted this revision.Apr 15 2021, 2:28 PM

LGTM

clang/lib/Tooling/NodeIntrospection.cpp
40–41

nit: rebase, this no longer exists.

69–71

nit: This is quite an inefficient way to go about comparing these. Though it would require a bit of work to avoid creation of the temporary strings.

This revision is now accepted and ready to land.Apr 15 2021, 2:28 PM