This is an archive of the discontinued LLVM Phabricator instance.

Differential D100513

[flang] Fix typo caught by clang build
ClosedPublic

Authored by klausler on Apr 14 2021, 3:03 PM.

Details

Reviewers
kiranchandramohan
Summary

An inadvertent ! operator was (fortunately) flagged as a
warning by clang; remove it.

Diff Detail

Event Timeline

klausler created this revision.Apr 14 2021, 3:03 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptApr 14 2021, 3:03 PM
klausler requested review of this revision.Apr 14 2021, 3:03 PM
kiranchandramohan accepted this revision.Apr 14 2021, 3:08 PM

LGTM.

Note: This patch fixes a buildbot failure.
https://lab.llvm.org/buildbot/#/builders/161/builds/104/steps/5/logs/stdio

This revision is now accepted and ready to land.Apr 14 2021, 3:08 PM
klausler mentioned this in rGe51939eca63c: [flang] Fix typo caught by clang build.Apr 14 2021, 3:10 PM
Harbormaster completed remote builds in B98774: Diff 337571.Apr 14 2021, 3:17 PM
klausler closed this revision.Apr 16 2021, 11:09 AM

Revision Contents

PathSize
flang/
runtime/
2 lines

Diff 337571

flang/runtime/io-error.cpp

Context not available.
ioStat_ = IostatEnd; ioStat_ = IostatEnd;
} }
} else if (iostatOrErrno == IostatEor && (flags_ & hasEor)) { } else if (iostatOrErrno == IostatEor && (flags_ & hasEor)) {
if (!ioStat_ == IostatOk || ioStat_ < IostatEor) { if (ioStat_ == IostatOk || ioStat_ < IostatEor) {
ioStat_ = IostatEor; // least priority ioStat_ = IostatEor; // least priority
} }
} else if (iostatOrErrno != IostatOk) { } else if (iostatOrErrno != IostatOk) {
Context not available.